Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to pure-Rust versions of bzip and zstd in order to pass static compiles #58

Merged
merged 3 commits into from
May 2, 2024

Conversation

Pr0methean
Copy link
Member

This replaces zip-rs/zip-old#429.

@Pr0methean Pr0methean enabled auto-merge May 1, 2024 17:56
@Pr0methean Pr0methean added this pull request to the merge queue May 1, 2024
Merged via the queue into master with commit f44ec4e May 2, 2024
23 checks passed
Pr0methean added a commit that referenced this pull request May 2, 2024
@Pr0methean Pr0methean mentioned this pull request May 2, 2024
@Pr0methean
Copy link
Member Author

@lolpro11 I've had to partially revert this PR. bzip2-rs isn't a replacement for bzip2 because the latter can compress and decompress and the former can only decompress. Even if that weren't the case, you would've needed to update the usages in read.rs and write.rs.

@lolpro11
Copy link
Contributor

lolpro11 commented May 2, 2024

@lolpro11 I've had to partially revert this PR. bzip2-rs isn't a replacement for bzip2 because the latter can compress and decompress and the former can only decompress. Even if that weren't the case, you would've needed to update the usages in read.rs and write.rs.

I understand. Thank you for telling me. The original reason for this PR is because it did not compile statically. Later I found out that bzip only needs the system library during compile time, allowing for proper static compiles.
Therefore, this PR only needed to change zstd (LZMA)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants