Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DEFINE instruction #139

Open
zippy opened this issue Apr 14, 2016 · 3 comments
Open

add DEFINE instruction #139

zippy opened this issue Apr 14, 2016 · 3 comments
Assignees
Milestone

Comments

@zippy
Copy link
Owner

zippy commented Apr 14, 2016

we need an instruction that allows us to add a new definition in to the receptor definitional space

@zippy zippy self-assigned this Apr 14, 2016
zippy added a commit that referenced this issue Apr 14, 2016
@zippy
Copy link
Owner Author

zippy commented Apr 14, 2016

4be1881 adds a DEFINE instruction... however, the signature is for SYMBOL_DEFINITION and a RESULT_SYMBOL. The code is generalized for all definition types, but our signatures don't allow optionality. So either we'd have to create an optionality semantic type to pass the data in (and return the correct type (i.e. RESULT_STRUCTURE..), or we'd have to create separate instructions for each semantic id type, i.e. DEFINE_SYMOBL, DEFINE_STRUCTURE, etc...
This raises the issue that at the ceptr level we've differentiated semantic types as different "things" whereas at the c level the semanticIDs are just different flavors of the same thing. It's worth keeping this in mind to make sure that's still the right decision.

@zippy zippy added partial and removed in progress labels Apr 14, 2016
@zippy zippy added this to the Proto Launch milestone Apr 14, 2016
@zippy zippy added in progress and removed partial labels Apr 16, 2016
@zippy
Copy link
Owner Author

zippy commented Apr 16, 2016

fb0d141 adds definitions for each semantic type

@zippy zippy closed this as completed Apr 16, 2016
@zippy zippy removed the in progress label Apr 16, 2016
@zippy zippy reopened this Apr 17, 2016
@zippy
Copy link
Owner Author

zippy commented Apr 17, 2016

Need to add a DECLARE instruction for symbols to match what we have in the base_defs so we can do recursive symbol definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant