Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined type property #1529

Merged
merged 4 commits into from
Jan 7, 2024
Merged

fix: undefined type property #1529

merged 4 commits into from
Jan 7, 2024

Conversation

DjordyKoert
Copy link
Contributor

Related to #1528

Using the old nullable notation combined with anyOf & allOf does not currently add the valid null type as an option.

DerManoMann
DerManoMann approved these changes Jan 7, 2024
View reviewed changes
Copy link
Collaborator

@DerManoMann DerManoMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now; in the long run moving all this code into a processor would be a good thing IMO.

I fixed the CS and phpstan issues on master - once this branch is updated I am happy to merge...

@DjordyKoert
Copy link
Contributor Author

@DerManoMann done! 😄

@DerManoMann DerManoMann merged commit 598958d into zircote:master Jan 7, 2024
20 checks passed
@DerManoMann
Copy link
Collaborator

Thanks @DjordyKoert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerManoMann DerManoMann DerManoMann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DjordyKoert @DerManoMann