Feature/issue 33 width issue #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgraded packages, modules and dependencies
* Fixed JSHint issues * Changed `onstyle` for `onClass` and `offstyle` for `offClass`
Collaborator
Author
|
You'll note that this PR includes the commits of the first PR I submitted ;-) |
* Removed global variables * Fixed the toggle initialization so that it doesn't toggle twice from on, to off, to on again * Removed unnecessary $watch of ngModel
* Really fixed the width issue. Using _scrollWidth_ works well and does not require checking the wrapper width.
Collaborator
Author
|
@ziscloud Any chance you approve and merge these PRs? I think they are worth it: important bug fixes and enhancements. Thanks! |
Collaborator
Author
|
thank you @ziscloud ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR, on top of the previous one (I can rebase if you don't want the 1st one for issue #31)
This one fixes the width of toggle to adjust for longer labels.