Fix height issues (as reported in issue #5) and various improvements #36
Conversation
|
Hi @ziscloud ! People were also asking if we could officially release this new version. How do we do this? (note: in my own dev environment, I set version to 0.3.0, so I wouldn't "mind" if you used the same version number... ;-) ) Thanks! |
…n behavior to version 0.1.1 * Re-implemented the `style` attribute, which is now replaced with `toggle-class` (more logical and consistent with `on-class` and `off-class` (`style` is still supported for backward compatibility) * Updated **index.html** to reflect the latest changes in the attributes * Moved **gh-pages** branch content to **master/** with some updates and so so that index.html automatically uses /dist files * Button size classes (`btn-lg`, `btn-sm`, etc.) are properly set to all elements as attribute `size` is specified * Button width and height automatically adjusts with the content size and font size (incl. a refresh once all fonts from the document are loaded) * Removed artifical `min-height` values for the various button sizes (it's automatic now) * Added support for empty buttons
bertysentry
force-pushed
the
feature/issue-5-height-does-not-work
branch
from
49f1230 to
360cb78
Compare
|
Hi @ziscloud, While waiting for your feedback, I made a few more changes:
When you merge this PR to master, you will need to change the settings of the GitHub project, so that the GitHub pages don't refer to the gh-pages branch, but rather to master. Thank you! I'm happy I could fix this great AngularJS directive and make it work as you originally intended! :-) |
|
Thank you @ziscloud for merging this. Now, would you allow me to publish this as version 0.4.0? |
2 participants
btn-lg,btn-sm, etc.) are properly set to all elements as attributesizeis specifiedmin-heightvalues for the various button sizes (it's automatic now)font-familypreset, as the toggle now properly adjust to any font type and size