fix: change handling of responses without url to respond to

pkg/provider/logout.go

@@ -60,7 +60,7 @@ func (p *IdentityProvider) logoutHandleFunc(w http.ResponseWriter, r *http.Reque
 			return nil
 		},
 		func() {
-			response.sendBackLogoutResponse(w, response.makeUnsupportedlLogoutResponse(fmt.Errorf("failed to decode request: %w", err).Error(), p.timeFormat))
+			http.Error(w, fmt.Errorf("failed to decode request: %w", err).Error(), http.StatusInternalServerError)
 		},
 	)
 

pkg/provider/logout_response.go

@@ -5,6 +5,7 @@ import (
 	"bytes"
 	"encoding/base64"
 	"encoding/xml"
+	"fmt"
 	"html/template"
 	"net/http"
 	"time"
@@ -52,14 +53,18 @@ func (r *LogoutResponse) sendBackLogoutResponse(w http.ResponseWriter, resp *sam
 		r.ErrorFunc(err)
 		return
 	}
-
-	samlMessage := base64.StdEncoding.EncodeToString(xmlbuff.Bytes())
+	samlMessageBytes := xmlbuff.Bytes()
 
 	data := LogoutResponseForm{
 		RelayState:   r.RelayState,
-		SAMLResponse: samlMessage,
+		SAMLResponse: base64.StdEncoding.EncodeToString(samlMessageBytes),
 		LogoutURL:    r.LogoutURL,
 	}
+	if data.LogoutURL == "" {
+		w.Write(samlMessageBytes)
+		http.Error(w, fmt.Errorf("failed to find logout url").Error(), http.StatusInternalServerError)
+		return
+	}
 
 	if err := r.LogoutTemplate.Execute(w, data); err != nil {
 		r.ErrorFunc(err)

pkg/provider/response.go

@@ -58,6 +58,11 @@ func (r *Response) doResponse(request *http.Request, w http.ResponseWriter, resp
 			r.AcsUrl,
 		}
 
+		if data.AssertionConsumerServiceURL == "" {
+			w.Write([]byte(response))
+			http.Error(w, fmt.Errorf("failed to find AssertionConsumerServiceURL").Error(), http.StatusInternalServerError)
+			return
+		}
 		if err := r.PostTemplate.Execute(w, data); err != nil {
 			r.ErrorFunc(err)
 			return