Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test:integration): install cypress binary #251

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Oct 29, 2024

The Cypress binary is only available when the pnpm dependencies cache is not hit, aka when pnpm install actually downloads dependencies. The problem is that a postinstall hook downloads the Cypress binary, which is not triggered when the dependencies are loaded from cache.

The solution is to cache the Cypress binary along with the pnpm dependencies.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • Vitest unit tests ensure that components produce expected outputs on different inputs.
  • Cypress integration tests ensure that login app pages work as expected. The ZITADEL API is mocked.
  • No debug or dead code
  • My code has no repetitions

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 0:34am

@eliobischof eliobischof self-assigned this Nov 2, 2024
@eliobischof eliobischof marked this pull request as ready for review November 2, 2024 00:48
@peintnermax peintnermax merged commit affe3c5 into qa Nov 11, 2024
7 checks passed
@peintnermax peintnermax deleted the install-cypress-binary branch November 11, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants