Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix grpc health check #268

Merged
merged 6 commits into from
Nov 12, 2024
Merged

test: fix grpc health check #268

merged 6 commits into from
Nov 12, 2024

Conversation

eliobischof
Copy link
Member

@eliobischof eliobischof commented Nov 4, 2024

Updates the zitadel-go library to v3 which allows to make unauthenticated gRPC health checks, switching the port as well as skipping TLS verification.

This is a requirement for having passing tests in #260, which should be merged asap.

Definition of Ready

  • I am happy with the code
  • Short description of the feature/issue is added in the pr description
  • PR is linked to the corresponding user story
  • Acceptance criteria are met
  • All open todos and follow ups are defined in a new ticket and justified
  • Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • No debug or dead code
  • My code has no repetitions
  • Documentation/examples are up-to-date
  • All non-functional requirements are met
  • If possible, the test configuration is adjusted so acceptance tests cover my changes

@eliobischof eliobischof enabled auto-merge (squash) November 11, 2024 16:39
@eliobischof eliobischof merged commit 0209e3f into main Nov 12, 2024
9 checks passed
@eliobischof eliobischof deleted the fix-grpc-health-check branch November 12, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants