Fixing a bug by remove the implicit cast to float if the class implem…

…ents __rpow__ . The fraction module would cast classes that have __rpow__ into floats. This change removes the implicit cast and if __rpow__ isn't there it will raise an exception
zitterbewegung · May 20, 2024 · 8d9d1d5 · 8d9d1d5
1 parent 16b46eb
commit 8d9d1d5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/Lib/fractions.py b/Lib/fractions.py
@@ -875,9 +875,13 @@ def __pow__(a, b):
  # A fractional power will generally produce an
  # irrational number.
  return float(a) ** float(b)
- else:
+
+ elif isinstance(b, (float, complex)):
  return float(a) ** b
 
+ else:
+ return NotImplemented
+
  def __rpow__(b, a):
  """a ** b"""
  if b._denominator == 1 and b._numerator >= 0:

diff --git a/Misc/ACKS b/Misc/ACKS
@@ -750,6 +750,7 @@ James Henstridge
 Kasun Herath
 Chris Herborth
 Ivan Herman
+Joshua Jay Herman
 Jürgen Hermann
 Gary Herron
 Ernie Hershey

diff --git a/Misc/NEWS.d/next/Library/2024-05-20-10-16-55.gh-issue-119189.KoYG89.rst b/Misc/NEWS.d/next/Library/2024-05-20-10-16-55.gh-issue-119189.KoYG89.rst
@@ -0,0 +1,2 @@
+Fixes a bug where fractions will not be casted into float when given as
+argument to __rpow__