Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How About Submenus? #1

Closed
BravishkaSkytano opened this issue Jun 23, 2020 · 8 comments
Closed

How About Submenus? #1

BravishkaSkytano opened this issue Jun 23, 2020 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BravishkaSkytano
Copy link

So I was looking for a basic Jekyll theme for a communal blog I'm developing and I couldn't choose between two, this theme and another called Sparrow. What I mostly liked about Sparrow was the submenus, they're perfect for my blog.

So I was thinking, what if you added submenus to your theme too! The Sparrow theme uses the slimMenu jQuery Navigation Menu Plugin, maybe it will work for this theme? I 'm a newbie when it comes to GitHub and developing so I don't really know how easy/difficult implementing that feature will be. Maybe I could add it?...

@BravishkaSkytano
Copy link
Author

I did a quick search for other ways to do this and I came across this article:
Jekyll + Bootstrap: Dynamic navigation bar with highlighting of the active element.
Maybe this will be better? It's dynamic but also uses Bootstrap (still not sure what that is lol. Mobile-ready sites?).

@ngzhio
Copy link
Collaborator

ngzhio commented Jun 24, 2020

Submenus sounds like good. Thanks for your suggestions.

Since the philosophy of Hamilton is to keep minimal, I won't use jQuery or Bootstrap, however. Instead, I'll try to hard code to implement this feature.

@BravishkaSkytano
Copy link
Author

Okay, great! I'm very excited to see what you come up with.

@ngzhio
Copy link
Collaborator

ngzhio commented Jun 24, 2020

Hi, @Aspiring-Writer, I have implemented this dropdown submenus feature, you can check it out through the demo page, hope you like it. Any advice is welcome!

@BravishkaSkytano
Copy link
Author

BravishkaSkytano commented Jun 24, 2020

It's perfect! I tried it on both my desktop and my tablet, it's really nice! Good job!

I will try it out on my blog and let you know how it goes. I'm excited!

@ngzhio
Copy link
Collaborator

ngzhio commented Jun 25, 2020

It's perfect! I tried it on both my desktop and my tablet, it's really nice! Good job!

I will try it out on my blog and let you know how it goes. I'm excited!

Thank you to like this theme.

@ngzhio ngzhio added enhancement New feature or request good first issue Good for newcomers labels Jun 25, 2020
@BravishkaSkytano
Copy link
Author

Of course! It's a good theme, you should be proud ;)

@ngzhio
Copy link
Collaborator

ngzhio commented Jun 27, 2020

Of course! It's a good theme, you should be proud ;)

Thank you. Any advice or PR is welcome.

@ngzhio ngzhio closed this as completed Jul 1, 2020
jb8io added a commit to jb8io/jb8 that referenced this issue Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants