Vue popper #1
Open
Vue popper #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1、服务器没有HTMLElement
esm临时使用umd，期待更好的方案
ziyoung
reviewed
Aug 14, 2018
| reference: HTMLElement, | ||
| popper: HTMLElement, | ||
| boundariesElement: [String, HTMLElement], | ||
| reference: Vue.prototype.$isServer ? {} : HTMLElement, |
There was a problem hiding this comment.
您的意思是传递参数时使用 isServer 判断传参数而不是在组件内直接使用 isServer 判断更改接收参数类型吗
|
@yuchonghua 非常感谢你的 pr。😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.