add option to add links to the footer of the page #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholbach
changed the title
|
@dholbach Thanks. I can see the use case, but I am not convinced about solution. The footer looks quite thick. Why not adding the links directly to existing footer section? "Additional Links" section is quite obvious, could use get just the links without the title? If you really want to have it in two separate rows, can we get rid of the the top |
Signed-off-by: Daniel Holbach <daniel.holbach@gmail.com>
dholbach
force-pushed
the
add-bottom-links
branch
from
71e9a0a to
1a2693c
Compare
|
Thanks for your feedback. Is this more to your liking now?
|
zjedi
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header menu might get a bit busy for pages with a lot of sections and links. So I thought it would be nice to add e.g. less important links to sub-pages you might be legally required to have, like license, imprint, copyright, etc. to the footer of the page.