Skip to content

Commit

Permalink
use nolyfill to remove some polyfills (go-gitea#31468)
Browse files Browse the repository at this point in the history
We don't need to have polyfills down to Node v4. Some of our deps have
polyfills, and don't utilize the built-in implementation if available.
While this does decrease our package graph, I haven't been able to
notice any decrease/increase in page load times, although that could
likely be just because it's already pretty fast.

Nolyfill is https://github.com/SukkaW/nolyfill

updates to files generated with:

```shell
npx nolyfill install
npm update
```

Before this is/isn't merged, I'd be appreciative/thankful for other's
insights.

Edit: This isn't due to a specific individual. I am generally supportive
of them and their dedication to backward compatibility. This PR is due
to not needing those imports for our minimum requirements. Please don't
take this PR as commentary on anyone's character.

---------

Co-authored-by: silverwind <me@silverwind.io>
  • Loading branch information
techknowlogick and silverwind authored Jul 24, 2024
1 parent c0b5a84 commit b4ccef3
Show file tree
Hide file tree
Showing 3 changed files with 346 additions and 1,615 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -887,6 +887,8 @@ update-js: node-check | node_modules
npx updates -u -f package.json
rm -rf node_modules package-lock.json
npm install --package-lock
npx nolyfill install
npm install --package-lock
@touch node_modules

.PHONY: update-py
Expand Down
Loading

0 comments on commit b4ccef3

Please sign in to comment.