Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR more or less replicates the behavior of #226 but replaces optimistic indexes with timestamps.
The general idea is to maintain a cache of pending transactions. These pending transactions are merged with already indexed transactions in response to a
/transactions/v2
request. The merge process is straightforward: it removes duplicates between the indexed and pending transactions based on commitment and adds the remaining pending transactions, sorted by timestamp, up to the specified limit.There are three events that trigger the removal of pending transactions:
One consequence of this PR is that
pendingDeltaIndex
in the/info
response is now less accurate. However, this shouldn't be an issue, as it is only used to estimate thelimit
value for the/transactions/v2
request.