fix(mmap): pre-allocate temp file before mmapping #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komar007
force-pushed
the
mmap_sparse_file_fix
branch
2 times, most recently
from
6ec7811 to
2790c66
Compare
|
looks like that's not in libc? Does this need a feature flag or something? |
komar007
force-pushed
the
mmap_sparse_file_fix
branch
3 times, most recently
from
4e165e3 to
f0cb8a4
Compare
|
It seems it's in libc only on linux. Plus it's way too late:) |
This avoids SIGBUS on memory write in case the temp file is sparse. Implemented for linux only; other target_os cfg values unchanged.
zkat
reviewed
May 19, 2023
Cargo.toml
Outdated
| @@ -16,6 +16,7 @@ digest = "0.10.6" | |||
| either = "1.6.1" | |||
| futures = "0.3.17" | |||
| hex = "0.4.3" | |||
| libc = "0.2.144" | |||
There was a problem hiding this comment.
could you make this an optional dependency that goes along with memmap? Since we don't use libc unless the mmap feature is enabled.
zkat
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids SIGBUS on memory write in case the temp file is sparse. Implemented for linux only; other target_os cfg values unchanged.
I am unsure windows and mac are affected by #48 and I cannot verify. If so, perhaps a similar fix is needed.