Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remove_fully) add option for remove cache entry #54

Merged
merged 1 commit into from
Oct 7, 2023
Merged

feat(remove_fully) add option for remove cache entry #54

merged 1 commit into from
Oct 7, 2023

Conversation

fiag
Copy link
Contributor

@fiag fiag commented Jun 30, 2023

pull request for #53

@zkat
Copy link
Owner

zkat commented Jul 26, 2023 •
edited
Loading

Looks like clippy needs some fixing

@CommanderStorm
Copy link

CommanderStorm commented Aug 1, 2023 •
edited
Loading

Looks like clippy needs some fixing

It does, but this is not the fault of this PR, as both of this issue is failing in main too:
clippy::lines_filter_map_ok was introduced in rust 1.70

It can be resolved via exchanging filter_map with map_while:
image

@zkat zkat linked an issue Oct 7, 2023 that may be closed by this pull request
pls add 'remove fully' option to remove() function #53
Closed
@zkat zkat merged commit 8134c4d into zkat:main Oct 7, 2023
1 of 7 checks passed
zkat pushed a commit that referenced this pull request Oct 7, 2023
@fiag @zkat
feat(remove_fully): add option for remove cache entry (#54)
34ee679 
Fixes: #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pls add 'remove fully' option to remove() function
3 participants
@fiag @zkat @CommanderStorm