Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the feature flags for compilation without the async runtime. Fixes #64. #65

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Conversation

kinire98
Copy link
Contributor

@kinire98 kinire98 commented Feb 9, 2024

Here is the feature flags added for the #64 issue. I tested it and it compiles fine.
I forgot to create a new branch, hope there is no problem in that.

@zkat
Copy link
Owner

zkat commented Feb 9, 2024

Looks like you need to add it to an import now, since it's not getting used anymore :)

@kinire98
Copy link
Contributor Author

kinire98 commented Feb 12, 2024

I don't understand. If it's not used in the library, shouldn't it be removed?
And I see it in the linkto module, but it is disabled, because feature = "link_to" is disabled

@kinire98
Copy link
Contributor Author

Maybe this last commit, is unwanted, because I changed the default features.

…odule without a conditional compilation flag
@kinire98
Copy link
Contributor Author

nvm. I found another module. Sorry for the repetition.

BREAKING CHANGE: this bumps the MSRV to 1.70.0
@zkat zkat merged commit ffa1ab7 into zkat:main Feb 12, 2024
7 checks passed
@zkat
Copy link
Owner

zkat commented Feb 15, 2024

This is released now as part of 13.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants