This repository has been archived by the owner on Aug 17, 2019. It is now read-only.
Make tests pass on Windows #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmg
commented
Sep 5, 2017
| @@ -11,7 +11,8 @@ let _config | |||
|
|
|||
| function readConfig () { | |||
| return new BB((resolve, reject) => { | |||
| const child = spawn('npm', ['config', 'ls', '--json'], { | |||
| const npmBin = process.platform === 'win32' ? 'npm.cmd' : 'npm' | |||
There was a problem hiding this comment.
Coincidentally, one alternative to this ternary is the package that inspired #8, strong-spawn-npm.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small tweak to the actual cipm code (
lib/config.js), but otherwise all the other changes are within the tests and test helpers.