This repository has been archived by the owner on Aug 17, 2019. It is now read-only.
fix(lifecycle): detect binding.gyp for default install lifecycle #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to detect if
binding.gyp
exists in a package without aninstall
lifecycle script, and if so adds the default install lifecycle scriptI opted to check for
binding.gyp
usingstatAsync
instead of readPkgJson.extras because the only thing needed here wasbinding.gyp
detection, not everything else provided byreadPkgJson.extras
I looked at adding a test but was unable to come up with a good way to make a fake
binding.gyp
that could output a detectable string. I'm open for suggestions though.