Declare minimum supported rust version at 1.56.0 (fixes CI) #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of
once_cell(1.15.0) bumped their msrv to 1.56.0. Miette didn't previously declare an MSRV, but we have a CI pass that tests against rust 1.54.0. As a result, CI is currently broken.There are a few options here:
once_celldependency as<1.15.0, and continue testing against rust 1.54.0.mietteitselfI don't have strong opinions about which of these options to go for, it's really up to the
miettemaintainers. Happy to switch out this PR for one of the other options if you would prefer.