This repository has been archived by the owner on Jul 3, 2019. It is now read-only.
port pacote over to npm-registry-fetch #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
force-pushed
the
zkat/regfetch
branch
3 times, most recently
from
e82e95f
to
bd0d013
Compare
This replaces all the fetch.js-related things with an external library. Additionally, config has been reduced to match what pacote actually uses. This changes the way retry, auth, and registry-related keys work such that they now use npm-style config names instead of the batched-up and camelCased versions. BREAKING CHANGE: config has changed significantly, especially for auth and registry-related configs. Refer to README.md for available options.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty significant patch! It reintegrates
npm-registry-fetchback into pacote after it was originally yanked out into its own library. As part of that change, this PR replaces the old config/options mechanism pacote was using withfiggy-pudding, which is itself used by other consuming libraries.