Migrate to digest 0.10
#18
Annotations
30 errors and 2 warnings
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L713
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:713:5
|
713 | / assert_eq!(
714 | | bool::from(
715 | | Fp2 {
716 | | c0: P_M1_OVER2,
... |
721 | | true
722 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L703
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:703:5
|
703 | / assert_eq!(
704 | | bool::from(
705 | | Fp2 {
706 | | c0: p_p1_over2,
... |
711 | | false
712 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L693
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:693:5
|
693 | / assert_eq!(
694 | | bool::from(
695 | | Fp2 {
696 | | c0: -Fp::one(),
... |
701 | | false
702 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L683
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:683:5
|
683 | / assert_eq!(
684 | | bool::from(
685 | | Fp2 {
686 | | c0: -Fp::one(),
... |
691 | | false
692 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L673
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:673:5
|
673 | / assert_eq!(
674 | | bool::from(
675 | | Fp2 {
676 | | c0: -Fp::one(),
... |
681 | | false
682 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L662
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:662:5
|
662 | / assert_eq!(
663 | | bool::from(
664 | | Fp2 {
665 | | c0: p_p1_over2,
... |
670 | | false
671 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L652
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:652:5
|
652 | / assert_eq!(
653 | | bool::from(
654 | | Fp2 {
655 | | c0: P_M1_OVER2,
... |
660 | | true
661 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L642
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:642:5
|
642 | / assert_eq!(
643 | | bool::from(
644 | | Fp2 {
645 | | c0: Fp::zero(),
... |
650 | | false
651 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L632
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:632:5
|
632 | / assert_eq!(
633 | | bool::from(
634 | | Fp2 {
635 | | c0: p_p1_over2,
... |
640 | | false
641 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L622
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:622:5
|
622 | / assert_eq!(
623 | | bool::from(
624 | | Fp2 {
625 | | c0: P_M1_OVER2,
... |
630 | | true
631 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L611
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:611:5
|
611 | / assert_eq!(
612 | | bool::from(
613 | | Fp2 {
614 | | c0: Fp::one(),
... |
619 | | true
620 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L601
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:601:5
|
601 | / assert_eq!(
602 | | bool::from(
603 | | Fp2 {
604 | | c0: Fp::zero(),
... |
609 | | false
610 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L591
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:591:5
|
591 | / assert_eq!(
592 | | bool::from(
593 | | Fp2 {
594 | | c0: p_p1_over2,
... |
599 | | false
600 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L581
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:581:5
|
581 | / assert_eq!(
582 | | bool::from(
583 | | Fp2 {
584 | | c0: p_p1_over2,
... |
589 | | false
590 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L569
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:569:5
|
569 | / assert_eq!(
570 | | bool::from(
571 | | Fp2 {
572 | | c0: Fp::one(),
... |
577 | | true
578 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L559
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:559:5
|
559 | / assert_eq!(
560 | | bool::from(
561 | | Fp2 {
562 | | c0: Fp::zero(),
... |
567 | | true
568 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L549
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:549:5
|
549 | / assert_eq!(
550 | | bool::from(
551 | | Fp2 {
552 | | c0: P_M1_OVER2,
... |
557 | | true
558 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L539
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:539:5
|
539 | / assert_eq!(
540 | | bool::from(
541 | | Fp2 {
542 | | c0: P_M1_OVER2,
... |
547 | | true
548 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L538
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:538:5
|
538 | assert_eq!(bool::from(Fp2::one().sgn0()), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L537
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:537:5
|
537 | assert_eq!(bool::from(Fp2::zero().sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L798
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:798:5
|
798 | assert_eq!(bool::from(p_p1_over2.sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L795
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:795:5
|
795 | assert_eq!(bool::from(P_M1_OVER2.sgn0()), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L794
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:794:5
|
794 | assert_eq!(bool::from((-Fp::zero()).sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L793
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:793:5
|
793 | assert_eq!(bool::from((-Fp::one()).sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L792
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:792:5
|
792 | assert_eq!(bool::from(Fp::one().sgn0()), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L791
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:791:5
|
791 | assert_eq!(bool::from(Fp::zero().sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= note: `-D clippy::bool-assert-comparison` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
5 bindings with single-character names in scope:
benches/groups.rs#L9
error: 5 bindings with single-character names in scope
--> benches/groups.rs:9:24
|
9 | fn criterion_benchmark(c: &mut Criterion) {
| ^
...
131 | let a = G2Projective::generator();
| ^
132 | let a_affine = G2Affine::generator();
133 | let s = Scalar::from_raw([1, 2, 3, 4]);
| ^
...
136 | let v = vec![G2Projective::generator(); N];
| ^
137 | let mut q = vec![G2Affine::identity(); N];
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
|
5 bindings with single-character names in scope:
benches/groups.rs#L9
error: 5 bindings with single-character names in scope
--> benches/groups.rs:9:24
|
9 | fn criterion_benchmark(c: &mut Criterion) {
| ^
...
62 | let a = G1Projective::generator();
| ^
63 | let a_affine = G1Affine::generator();
64 | let s = Scalar::from_raw([1, 2, 3, 4]);
| ^
...
67 | let v = vec![G1Projective::generator(); N];
| ^
68 | let mut q = vec![G1Affine::identity(); N];
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
|
5 bindings with single-character names in scope:
benches/groups.rs#L9
error: 5 bindings with single-character names in scope
--> benches/groups.rs:9:24
|
9 | fn criterion_benchmark(c: &mut Criterion) {
| ^
...
62 | let a = G1Projective::generator();
| ^
63 | let a_affine = G1Affine::generator();
64 | let s = Scalar::from_raw([1, 2, 3, 4]);
| ^
...
67 | let v = vec![G1Projective::generator(); N];
| ^
68 | let mut q = vec![G1Affine::identity(); N];
| ^
|
= note: `-D clippy::many-single-char-names` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy (beta)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|