Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in zkp2p/zk-p2p#113, the current
VarShiftLeft
template does not check that the given shift is at the first position of the non-masked string.It allows an adversary to extract an arbitrary substring of the non-masked string.
I added
VarShiftMaskedStr
andShiftAndPackMaskedStr
inpackages/circuits/helpers/extract.circom
to fix that issue in the following approach.shift
.in[shift]
is not zero.shift
is zero orin[shift-1]
is zero.