Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for DKIM Reg #135

Merged
merged 9 commits into from
Nov 9, 2023
Merged

Script for DKIM Reg #135

merged 9 commits into from
Nov 9, 2023

Conversation

saleel
Copy link
Member

@saleel saleel commented Nov 6, 2023

  • Add scripts package.
  • Modify dkim key script to work with new DKIMRegistry.sol (Use poseidon_hash(pubkey))
  • Remove defaults from DKIMregistry.sol
  • Add option for setting multiple keys for a domain in one tx in DKIMregistry.sol
  • Remove MailServer.sol

@@ -0,0 +1,21 @@
{
"name": "@zk-email/scripts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should just go in helpers imo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or this dkim selector archive site can be its own site

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should just go in helpers imo?

I thought of it, but helpers is a sdk that other people would be importing to their code. We don't want these scripts to be part of it right.

@Divide-By-0
Copy link
Member

Typescript errors for me:
Cannot find module '@zk-email/contracts/out/DKIMRegistry.sol/DKIMRegistry.json' or its corresponding type declarations.ts(2307)
import { abi } from "@zk-email/contracts/out/DKIMRegistry.sol/DKIMRegistry.json";

And I also don't see /out in contracts...

@saleel
Copy link
Member Author

saleel commented Nov 7, 2023

Typescript errors for me: Cannot find module '@zk-email/contracts/out/DKIMRegistry.sol/DKIMRegistry.json' or its corresponding type declarations.ts(2307) import { abi } from "@zk-email/contracts/out/DKIMRegistry.sol/DKIMRegistry.json";

And I also don't see /out in contracts...

They will be generated when you run yarn build in contracts.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/circomlibjs 0.1.5 None +0 11.2 kB types

@saleel saleel marked this pull request as ready for review November 9, 2023 09:37
@Divide-By-0 Divide-By-0 merged commit 907f950 into main Nov 9, 2023
6 checks passed
@saleel saleel deleted the dkim-reg-script branch April 19, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants