Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to resolve DNS from ZKEmail Archive when HTTP DNS fails #227

Merged
merged 7 commits into from
Oct 12, 2024
Merged

Add an option to resolve DNS from ZKEmail Archive when HTTP DNS fails #227

merged 7 commits into from
Oct 12, 2024

Conversation

saleel
Copy link
Member

@saleel saleel commented Oct 10, 2024 •
edited
Loading

Description

Add an option to use ZKEmail DNS Archive as a fallback when HTTP DNS fails

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@saleel saleel changed the title Add an option for archive.prove.email DNS resolution when HTTP DNS fails Add an option for resolve from ZKEmail Archive when HTTP DNS fails Oct 10, 2024
@saleel saleel changed the title Add an option for resolve from ZKEmail Archive when HTTP DNS fails Add an option to resolve DNS from ZKEmail Archive when HTTP DNS fails Oct 10, 2024
saleel
saleel commented Oct 10, 2024
View reviewed changes
packages/helpers/src/dkim/dns-over-http.ts
@@ -0,0 +1,131 @@
import { CustomError } from "../lib/mailauth/tools";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically lib/mailauth/Doh.ts moved here

@Divide-By-0 Divide-By-0 merged commit 6e08c67 into main Oct 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saleel @Divide-By-0