-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to monorepo #80
Conversation
saleel
commented
Jun 12, 2023
•
edited
Loading
edited
- Switch to monorepo pattern with yarn workspace
- Move twitter specific circuit/contracts to separate package
- Add tests for email verifier circuit
- Add tests for twitter circuit
- Add helpers library with reusable utils
.gitignore
Outdated
src/contracts/out/ | ||
src/contracts/lib/ | ||
src/contracts/broadcast | ||
pacakges/contracts/out/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo on packages
dizkus-scripts/4_gen_vkey.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait so where did this file go? is there an updated readme for how to compile/run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scripts folder was moved to packages/twitter-verifier-circuits/scripts
along with the circom files for twitter.
I have to update the paths in Readme. I will do it if the structure makes sense.
Cool -- some minor merge conflicts but other than that, code looks fine to me. Would be great to update the readme so its up to date with the new structure! I don't have enough experience with npm package structures so willing to trust your experience here on that. |
Yea, I will fix the conflicts and update the Readme. Some existing stuff in the Readme was also updated if I remember correctly. Another thing that could be improved is the |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
7202475 | Generic High Entropy Secret | 58864c8 | packages/twitter-verifier-app/index.jsx | View secret |
7202475 | Generic High Entropy Secret | bf7967c | packages/twitter-verifier-app/index.jsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
4133721
to
44a30f7
Compare