Strict dependencies cause conflict with other libraries

[seemenkina]

There is a situation where ark-zkey is forced to depend on a rather old version of num-traits, which is now not compatible with some of the other library which are already written for 2.19 by default.

Unfortunately it doesn't depend on it directly, so I can't open direct PR:

https://github.com/vimwitch/circom-compat.git - fork from old ark-circom which restrict version on 2.15
ark-zkey use this fork and also restrict version on 2.15

I'll be really appreciate if we can solve this issue and bump dependencies because zerokit also have to update this deps or I can't use it at all in our new project

[vivianjeng]

Hi thank you for reporting this issue

I am not sure what's your purpose of using ark-zkey. Size or read_arkzkey performance?
But we have already improved read_zkey much more than arkworks/circom-compat
you can refer to this

• feat(core): update read_zkey with new_unchecked mopro#129
  • it improves reading keccak256 zkey from 115.82s to 1.56s
• fix: use BufReader for zkey mopro#197
  • it improves reading keccak256 zkey from 7.57s to 60 ms
• we have made the update here and here

[seemenkina]

Thank you for your quick response and help

The Idea was that we need only part related to reading ark-zkey in zerokit and using mopro caused this issue: zkmopro/mopro#131

So for us much easier work with separate crate

[vivianjeng]

I see!
thank you for your response!

I think you can just import circom-compat to use read_zkey
because now we also use the dependency of ark-circom to read zkeys

ark-zkey/Cargo.toml

Line 27 in f42e9a3

ark-circom = { version = "0.5.0"}

(and now there is no wasmer patch in mopro anymore)

and we are building another crate circom-prover: zkmopro/mopro#299
https://github.com/zkmopro/mopro/tree/main/circom-prover
which provides better performance than ark-circom
and including read_zkey (but still WIP)

I will keep you updated when we finish this 🙏🏻