Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies to latest versions #276

Merged
merged 12 commits into from
Feb 7, 2025
Merged

chore: Update dependencies to latest versions #276

merged 12 commits into from
Feb 7, 2025

Conversation

seemenkina
Copy link
Collaborator

@seemenkina seemenkina commented Jan 29, 2025

UPD: As a result it was decided to deprecate the wasm part, besides here also the makefile is fixed and so far the work with arkzkey is completely inside the code without using the library (todo: consider the option of returning to mopro )


Main problem: zerokit fixes many dependencies and some versions are too old and new libraries don't support them and a conflict happened

the main conflict is around once_cell and num_traits

once_cell - already fixed

num_traits - cannot be fixed yet because this strict dependency came from ark-zkey, and there it in turn came from a fork on an old version of arc-circom where version 2.15 is fixed

Open issue in ark-zkey: zkmopro/ark-zkey#1

Upgrade various dependencies across multiple crates to their latest compatible versions
Copy link

Benchmark for b87ce19

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 856.6±5.80ns 895.2±10.96ns +4.51%
FullMerkleTree::get 3.5±0.09ns 3.5±0.15ns 0.00%
FullMerkleTree::get_empty_leaves_indices 7.5±0.10ns 7.5±0.13ns 0.00%
FullMerkleTree::get_subtree_root 3.7±0.09ns 3.7±0.22ns 0.00%
FullMerkleTree::override_range 1316.3±12.62ns 1348.2±20.09ns +2.42%
FullMerkleTree::set 863.2±9.34ns 891.6±20.74ns +3.29%
OptimalMerkleTree::compute_root 999.6±19.95ns 1010.4±31.35ns +1.08%
OptimalMerkleTree::delete 991.2±18.08ns 1026.6±11.19ns +3.57%
OptimalMerkleTree::get 23.1±1.48ns 21.5±0.24ns -6.93%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.10ns 7.5±0.13ns 0.00%
OptimalMerkleTree::get_subtree_root 24.6±0.18ns 23.9±0.40ns -2.85%
OptimalMerkleTree::override_range 4.1±0.06µs 4.3±0.12µs +4.88%
OptimalMerkleTree::set 989.6±21.67ns 1027.4±17.52ns +3.82%

Copy link

Benchmark for b87ce19

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.2±0.11ms 14.1±0.11ms -0.70%
OptimalMerkleTree::::full_height_gen 586.3±15.99µs 585.8±13.57µs -0.09%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 354.7±5.40ns 362.1±4.38ns +2.09%
Pmtree::get_empty_leaves_indices 9.0±1.52ns 9.0±0.14ns 0.00%
Pmtree::get_subtree_root 514.9±6.71ns 504.3±6.53ns -2.06%
Pmtree::override_range 233.3±3.67µs 239.1±7.91µs +2.49%
Pmtree::set 54.8±0.42µs 55.0±0.49µs +0.36%
Pmtree:delete 54.8±0.54µs 54.8±0.40µs 0.00%
Set/FullMerkleTree::::set/1 561.8±3.61µs 561.4±2.78µs -0.07%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.6±0.02ms 0.00%
Set/FullMerkleTree::::set/100 56.1±0.06ms 56.2±0.19ms +0.18%
Set/FullMerkleTree::::set_range/1 562.5±5.39µs 559.5±3.82µs -0.53%
Set/FullMerkleTree::::set_range/10 765.6±6.34µs 763.7±7.00µs -0.25%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.15ms 0.00%
Set/OptimalMerkleTree::::set/1 567.0±2.96µs 561.8±4.86µs -0.92%
Set/OptimalMerkleTree::::set/10 5.6±0.02ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set/100 56.7±0.27ms 56.0±0.13ms -1.23%
Set/OptimalMerkleTree::::set_range/1 565.0±6.13µs 563.5±6.45µs -0.27%
Set/OptimalMerkleTree::::set_range/10 5.7±0.16ms 5.7±0.02ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.7±0.13ms 56.3±0.22ms -0.71%
vk::vk_from_ark_serialized 1598.9±6.39ns 1579.5±26.83ns -1.21%
zkey::zkey_from_raw 3.4±0.01s 3.4±0.01s 0.00%

…eases

Upgrade serde and serde_json dependency versions using more flexible version specifiers
Copy link

Benchmark for 101da62

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 865.5±17.01ns 870.8±5.82ns +0.61%
FullMerkleTree::get 3.4±0.04ns 3.5±0.07ns +2.94%
FullMerkleTree::get_empty_leaves_indices 7.5±0.11ns 7.5±0.11ns 0.00%
FullMerkleTree::get_subtree_root 3.7±0.16ns 3.8±0.11ns +2.70%
FullMerkleTree::override_range 1322.0±10.82ns 1337.8±33.67ns +1.20%
FullMerkleTree::set 856.0±10.73ns 877.0±11.96ns +2.45%
OptimalMerkleTree::compute_root 995.3±9.47ns 1007.4±8.47ns +1.22%
OptimalMerkleTree::delete 987.8±12.18ns 1006.2±15.76ns +1.86%
OptimalMerkleTree::get 22.0±0.26ns 22.0±0.20ns 0.00%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.16ns 7.5±0.10ns 0.00%
OptimalMerkleTree::get_subtree_root 24.0±0.28ns 24.1±0.26ns +0.42%
OptimalMerkleTree::override_range 4.1±0.07µs 4.1±0.04µs 0.00%
OptimalMerkleTree::set 990.5±35.23ns 1001.7±8.19ns +1.13%

Copy link

Benchmark for b87ce19

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.0±0.30ms 14.0±0.08ms 0.00%
OptimalMerkleTree::::full_height_gen 578.6±10.00µs 576.6±7.04µs -0.35%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 358.1±4.09ns 356.8±3.50ns -0.36%
Pmtree::get_empty_leaves_indices 8.7±0.11ns 9.0±0.07ns +3.45%
Pmtree::get_subtree_root 513.4±7.85ns 502.0±5.31ns -2.22%
Pmtree::override_range 233.6±3.30µs 235.1±4.03µs +0.64%
Pmtree::set 55.6±5.15µs 54.3±0.51µs -2.34%
Pmtree:delete 54.5±0.50µs 54.6±0.36µs +0.18%
Set/FullMerkleTree::::set/1 559.4±4.67µs 556.4±9.68µs -0.54%
Set/FullMerkleTree::::set/10 5.6±0.01ms 5.6±0.02ms 0.00%
Set/FullMerkleTree::::set/100 56.3±0.14ms 55.5±0.11ms -1.42%
Set/FullMerkleTree::::set_range/1 559.1±3.06µs 555.2±3.46µs -0.70%
Set/FullMerkleTree::::set_range/10 762.6±6.97µs 753.7±5.13µs -1.17%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 558.4±5.64µs 557.6±5.73µs -0.14%
Set/OptimalMerkleTree::::set/10 5.6±0.03ms 5.6±0.08ms 0.00%
Set/OptimalMerkleTree::::set/100 55.9±0.12ms 55.6±0.12ms -0.54%
Set/OptimalMerkleTree::::set_range/1 560.2±5.16µs 556.5±6.43µs -0.66%
Set/OptimalMerkleTree::::set_range/10 5.6±0.01ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.2±0.24ms 55.7±0.09ms -0.89%
arkzkey::arkzkey_from_raw_compressed 338.7±0.23ms 342.4±0.28ms +1.09%
arkzkey::arkzkey_from_raw_uncompressed 6.0±0.01ms 6.0±0.03ms 0.00%
vk::vk_from_ark_serialized 1629.1±11.81ns 1614.6±7.39ns -0.89%
zkey::zkey_from_raw 3.5±0.00s 3.4±0.00s -2.86%

Copy link

Benchmark for 101da62

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.7±0.18ms 14.9±0.18ms +1.36%
OptimalMerkleTree::::full_height_gen 590.7±4.13µs 582.2±8.93µs -1.44%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 363.8±3.99ns 362.6±4.77ns -0.33%
Pmtree::get_empty_leaves_indices 8.7±0.13ns 8.7±0.12ns 0.00%
Pmtree::get_subtree_root 509.5±6.79ns 505.4±7.20ns -0.80%
Pmtree::override_range 243.0±7.98µs 238.8±7.05µs -1.73%
Pmtree::set 55.0±0.86µs 55.0±1.50µs 0.00%
Pmtree:delete 54.9±0.49µs 55.1±0.44µs +0.36%
Set/FullMerkleTree::::set/1 561.4±6.69µs 560.2±5.95µs -0.21%
Set/FullMerkleTree::::set/10 5.6±0.03ms 5.6±0.02ms 0.00%
Set/FullMerkleTree::::set/100 56.2±0.16ms 56.1±0.18ms -0.18%
Set/FullMerkleTree::::set_range/1 559.2±4.18µs 561.6±9.17µs +0.43%
Set/FullMerkleTree::::set_range/10 760.2±2.58µs 761.1±12.56µs +0.12%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.00ms 0.00%
Set/OptimalMerkleTree::::set/1 561.6±4.63µs 561.5±7.55µs -0.02%
Set/OptimalMerkleTree::::set/10 5.6±0.01ms 5.6±0.05ms 0.00%
Set/OptimalMerkleTree::::set/100 56.4±0.18ms 56.1±0.17ms -0.53%
Set/OptimalMerkleTree::::set_range/1 562.2±4.20µs 560.3±4.72µs -0.34%
Set/OptimalMerkleTree::::set_range/10 5.7±0.14ms 5.6±0.01ms -1.75%
Set/OptimalMerkleTree::::set_range/100 56.6±1.06ms 56.1±0.26ms -0.88%
vk::vk_from_ark_serialized 1603.7±7.87ns 1534.5±7.54ns -4.32%
zkey::zkey_from_raw 3.4±0.00s 3.4±0.01s 0.00%

Copy link

Benchmark for 101da62

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.2±0.11ms 14.2±0.13ms 0.00%
OptimalMerkleTree::::full_height_gen 584.3±5.50µs 580.2±10.72µs -0.70%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 363.4±4.52ns 359.9±5.43ns -0.96%
Pmtree::get_empty_leaves_indices 8.7±0.11ns 8.7±0.08ns 0.00%
Pmtree::get_subtree_root 512.7±6.31ns 533.3±5.52ns +4.02%
Pmtree::override_range 236.7±6.62µs 241.5±8.16µs +2.03%
Pmtree::set 55.0±1.20µs 53.9±0.37µs -2.00%
Pmtree:delete 54.7±0.57µs 53.8±0.52µs -1.65%
Set/FullMerkleTree::::set/1 559.3±5.96µs 556.6±3.97µs -0.48%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.6±0.00ms 0.00%
Set/FullMerkleTree::::set/100 56.0±0.44ms 55.7±0.18ms -0.54%
Set/FullMerkleTree::::set_range/1 558.0±4.48µs 555.8±3.97µs -0.39%
Set/FullMerkleTree::::set_range/10 760.2±7.52µs 755.4±4.11µs -0.63%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.00ms 0.00%
Set/OptimalMerkleTree::::set/1 561.9±5.95µs 555.1±5.19µs -1.21%
Set/OptimalMerkleTree::::set/10 5.6±0.01ms 5.6±0.02ms 0.00%
Set/OptimalMerkleTree::::set/100 56.1±0.18ms 55.7±0.19ms -0.71%
Set/OptimalMerkleTree::::set_range/1 559.2±3.84µs 555.0±2.80µs -0.75%
Set/OptimalMerkleTree::::set_range/10 5.6±0.01ms 5.6±0.03ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.1±0.24ms 55.7±0.17ms -0.71%
arkzkey::arkzkey_from_raw_compressed 339.3±0.58ms 344.6±0.57ms +1.56%
arkzkey::arkzkey_from_raw_uncompressed 6.0±0.02ms 6.0±0.02ms 0.00%
vk::vk_from_ark_serialized 1660.1±20.10ns 1603.9±7.31ns -3.39%
zkey::zkey_from_raw 3.5±0.00s 3.4±0.00s -2.86%

@vivianjeng
Copy link

please check this zkmopro/ark-zkey#1 (comment)
and the new crate is published
https://crates.io/crates/ark-zkey/0.1.2

Upgrade Ark and Wasmer dependencies to their latest minor versions, including:
- ark-circom from 0.1.0 to 0.5.0
- ark-zkey from 0.1.0 to 0.1.2
- wasmer from 2.3.0 to 2.3.x
- num-traits to 0.2.19

Also update Makefile to improve cross-platform build process for wabt
Copy link

Benchmark for c6c0158

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 876.7±4.36ns 871.1±9.10ns -0.64%
FullMerkleTree::get 3.4±0.04ns 3.5±0.12ns +2.94%
FullMerkleTree::get_empty_leaves_indices 7.5±0.17ns 7.8±0.22ns +4.00%
FullMerkleTree::get_subtree_root 3.6±0.20ns 3.7±0.09ns +2.78%
FullMerkleTree::override_range 1345.1±13.36ns 1362.0±39.79ns +1.26%
FullMerkleTree::set 856.2±5.87ns 887.5±9.82ns +3.66%
OptimalMerkleTree::compute_root 1007.5±11.55ns 1007.3±15.90ns -0.02%
OptimalMerkleTree::delete 993.1±6.30ns 1003.0±7.77ns +1.00%
OptimalMerkleTree::get 22.1±0.19ns 22.4±0.45ns +1.36%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.09ns 7.5±0.11ns 0.00%
OptimalMerkleTree::get_subtree_root 24.1±0.22ns 24.4±0.26ns +1.24%
OptimalMerkleTree::override_range 4.2±0.11µs 4.1±0.16µs -2.38%
OptimalMerkleTree::set 992.2±12.11ns 1000.6±7.89ns +0.85%

Copy link

Benchmark for 6f4bd0a

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 879.9±10.32ns 884.7±10.11ns +0.55%
FullMerkleTree::get 3.5±0.11ns 3.5±0.12ns 0.00%
FullMerkleTree::get_empty_leaves_indices 7.5±0.07ns 7.5±0.05ns 0.00%
FullMerkleTree::get_subtree_root 3.6±0.19ns 3.7±0.06ns +2.78%
FullMerkleTree::override_range 1352.5±15.11ns 1331.4±15.74ns -1.56%
FullMerkleTree::set 871.0±7.84ns 883.1±10.22ns +1.39%
OptimalMerkleTree::compute_root 995.3±10.23ns 1041.4±11.76ns +4.63%
OptimalMerkleTree::delete 1003.0±8.18ns 1030.0±10.07ns +2.69%
OptimalMerkleTree::get 22.0±0.27ns 22.1±0.17ns +0.45%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.09ns 7.5±0.10ns 0.00%
OptimalMerkleTree::get_subtree_root 24.1±0.26ns 23.9±0.41ns -0.83%
OptimalMerkleTree::override_range 4.1±0.15µs 4.1±0.06µs 0.00%
OptimalMerkleTree::set 1001.5±15.56ns 1019.4±5.84ns +1.79%

Remove ark-zkey optional dependency and update Wasmer to version 4.4.0 across multiple crates. Modify circuit module to include necessary structs and functions previously provided by ark-zkey.
Copy link

Benchmark for 4af8d2b

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 866.0±14.43ns 869.6±6.24ns +0.42%
FullMerkleTree::get 3.4±0.03ns 3.5±0.07ns +2.94%
FullMerkleTree::get_empty_leaves_indices 7.5±0.12ns 7.5±0.09ns 0.00%
FullMerkleTree::get_subtree_root 3.6±0.16ns 3.7±0.09ns +2.78%
FullMerkleTree::override_range 1344.5±10.91ns 1333.7±19.74ns -0.80%
FullMerkleTree::set 856.6±6.82ns 876.0±4.12ns +2.26%
OptimalMerkleTree::compute_root 996.3±9.55ns 1006.6±13.90ns +1.03%
OptimalMerkleTree::delete 1009.7±8.10ns 1008.5±41.36ns -0.12%
OptimalMerkleTree::get 25.5±0.21ns 22.1±0.28ns -13.33%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.11ns 7.5±0.11ns 0.00%
OptimalMerkleTree::get_subtree_root 24.1±0.29ns 23.8±0.29ns -1.24%
OptimalMerkleTree::override_range 4.1±0.13µs 4.1±0.13µs 0.00%
OptimalMerkleTree::set 989.3±11.37ns 1000.5±11.29ns +1.13%

Copy link

Benchmark for 3dd5515

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 885.2±9.95ns 885.7±22.37ns +0.06%
FullMerkleTree::get 3.4±0.06ns 3.5±0.08ns +2.94%
FullMerkleTree::get_empty_leaves_indices 7.5±0.06ns 7.5±0.10ns 0.00%
FullMerkleTree::get_subtree_root 3.6±0.13ns 3.7±0.09ns +2.78%
FullMerkleTree::override_range 1431.5±15.07ns 1332.4±16.13ns -6.92%
FullMerkleTree::set 859.5±8.35ns 877.4±10.74ns +2.08%
OptimalMerkleTree::compute_root 996.0±15.48ns 1008.1±12.59ns +1.21%
OptimalMerkleTree::delete 989.7±6.16ns 1006.3±10.58ns +1.68%
OptimalMerkleTree::get 22.0±0.32ns 24.3±0.20ns +10.45%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.10ns 7.5±0.11ns 0.00%
OptimalMerkleTree::get_subtree_root 24.1±0.51ns 23.9±0.31ns -0.83%
OptimalMerkleTree::override_range 4.1±0.05µs 4.1±0.19µs 0.00%
OptimalMerkleTree::set 989.1±10.51ns 1028.4±79.43ns +3.97%

Copy link

Benchmark for 4af8d2b

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.4±0.10ms 13.7±0.10ms -4.86%
OptimalMerkleTree::::full_height_gen 594.3±6.45µs 582.3±13.42µs -2.02%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 359.0±3.13ns 357.5±5.38ns -0.42%
Pmtree::get_empty_leaves_indices 8.7±0.08ns 8.7±0.12ns 0.00%
Pmtree::get_subtree_root 517.0±5.01ns 500.0±17.33ns -3.29%
Pmtree::override_range 241.8±5.67µs 245.2±4.97µs +1.41%
Pmtree::set 56.6±0.56µs 54.9±1.81µs -3.00%
Pmtree:delete 56.6±0.58µs 54.9±0.56µs -3.00%
Set/FullMerkleTree::::set/1 562.1±4.84µs 558.6±15.47µs -0.62%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.6±0.02ms 0.00%
Set/FullMerkleTree::::set/100 56.3±0.06ms 55.9±0.38ms -0.71%
Set/FullMerkleTree::::set_range/1 557.7±4.69µs 557.8±3.89µs +0.02%
Set/FullMerkleTree::::set_range/10 764.8±5.06µs 760.8±4.27µs -0.52%
Set/FullMerkleTree::::set_range/100 3.3±0.04ms 3.3±0.02ms 0.00%
Set/OptimalMerkleTree::::set/1 564.7±4.88µs 585.8±6.03µs +3.74%
Set/OptimalMerkleTree::::set/10 5.6±0.03ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set/100 56.5±0.14ms 56.5±0.16ms 0.00%
Set/OptimalMerkleTree::::set_range/1 568.4±5.92µs 564.5±7.79µs -0.69%
Set/OptimalMerkleTree::::set_range/10 5.7±0.01ms 5.6±0.02ms -1.75%
Set/OptimalMerkleTree::::set_range/100 57.1±0.42ms 56.6±0.61ms -0.88%
vk::vk_from_ark_serialized 1593.6±19.82ns 1584.8±7.88ns -0.55%
zkey::zkey_from_raw 3.5±0.00s 3.4±0.01s -2.86%

Copy link

Benchmark for 3dd5515

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.5±0.09ms 13.1±0.07ms -9.66%
OptimalMerkleTree::::full_height_gen 581.8±5.83µs 595.6±5.54µs +2.37%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 355.5±2.65ns 359.1±4.25ns +1.01%
Pmtree::get_empty_leaves_indices 10.2±0.09ns 8.7±0.11ns -14.71%
Pmtree::get_subtree_root 515.8±5.09ns 498.1±13.00ns -3.43%
Pmtree::override_range 238.6±7.47µs 246.4±4.22µs +3.27%
Pmtree::set 55.0±1.46µs 54.6±0.31µs -0.73%
Pmtree:delete 54.8±0.37µs 54.5±0.61µs -0.55%
Set/FullMerkleTree::::set/1 562.5±5.48µs 558.2±2.75µs -0.76%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.6±0.02ms 0.00%
Set/FullMerkleTree::::set/100 56.3±0.16ms 55.9±0.14ms -0.71%
Set/FullMerkleTree::::set_range/1 559.0±10.22µs 558.7±4.23µs -0.05%
Set/FullMerkleTree::::set_range/10 763.4±7.31µs 760.1±6.93µs -0.43%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 563.3±4.95µs 558.3±3.57µs -0.89%
Set/OptimalMerkleTree::::set/10 5.6±0.01ms 5.6±0.15ms 0.00%
Set/OptimalMerkleTree::::set/100 56.5±0.19ms 55.9±0.10ms -1.06%
Set/OptimalMerkleTree::::set_range/1 565.5±5.63µs 558.5±3.55µs -1.24%
Set/OptimalMerkleTree::::set_range/10 5.6±0.04ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.5±0.23ms 56.1±0.19ms -0.71%
vk::vk_from_ark_serialized 1600.5±8.42ns 1586.7±5.65ns -0.86%
zkey::zkey_from_raw 3.5±0.01s 3.4±0.01s -2.86%

Copy link

Benchmark for 4af8d2b

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.5±0.10ms 13.7±0.47ms -5.52%
OptimalMerkleTree::::full_height_gen 583.8±5.68µs 583.4±7.53µs -0.07%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 365.2±17.06ns 355.0±4.45ns -2.79%
Pmtree::get_empty_leaves_indices 8.7±0.14ns 8.8±0.23ns +1.15%
Pmtree::get_subtree_root 509.3±6.34ns 509.4±22.63ns +0.02%
Pmtree::override_range 238.8±4.23µs 245.4±3.82µs +2.76%
Pmtree::set 54.8±0.63µs 54.3±0.64µs -0.91%
Pmtree:delete 54.6±0.59µs 54.2±0.36µs -0.73%
Set/FullMerkleTree::::set/1 558.9±2.86µs 555.4±3.80µs -0.63%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.6±0.03ms 0.00%
Set/FullMerkleTree::::set/100 56.1±0.48ms 55.7±0.14ms -0.71%
Set/FullMerkleTree::::set_range/1 559.9±4.10µs 559.5±20.50µs -0.07%
Set/FullMerkleTree::::set_range/10 761.0±4.95µs 755.0±5.50µs -0.79%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 561.9±5.57µs 563.4±33.07µs +0.27%
Set/OptimalMerkleTree::::set/10 5.6±0.16ms 5.6±0.04ms 0.00%
Set/OptimalMerkleTree::::set/100 56.2±0.14ms 55.7±0.20ms -0.89%
Set/OptimalMerkleTree::::set_range/1 561.3±5.22µs 557.6±2.80µs -0.66%
Set/OptimalMerkleTree::::set_range/10 5.6±0.01ms 5.6±0.25ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.4±0.06ms 56.1±0.39ms -0.53%
arkzkey::arkzkey_from_raw_compressed 339.3±0.46ms 340.8±0.88ms +0.44%
arkzkey::arkzkey_from_raw_uncompressed 6.0±0.01ms 6.1±0.02ms +1.67%
vk::vk_from_ark_serialized 1639.2±20.96ns 1645.7±7.49ns +0.40%
zkey::zkey_from_raw 3.5±0.01s 3.4±0.01s -2.86%

Copy link

Benchmark for 3dd5515

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.0±0.26ms 13.1±0.08ms -6.43%
OptimalMerkleTree::::full_height_gen 580.1±7.81µs 578.3±2.92µs -0.31%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 368.1±20.61ns 355.9±3.23ns -3.31%
Pmtree::get_empty_leaves_indices 8.7±0.10ns 8.7±0.07ns 0.00%
Pmtree::get_subtree_root 515.5±14.51ns 509.9±5.34ns -1.09%
Pmtree::override_range 237.2±3.66µs 241.8±4.37µs +1.94%
Pmtree::set 54.7±0.37µs 54.6±1.95µs -0.18%
Pmtree:delete 55.1±1.46µs 54.5±0.33µs -1.09%
Set/FullMerkleTree::::set/1 558.1±6.31µs 558.1±11.10µs 0.00%
Set/FullMerkleTree::::set/10 5.6±0.03ms 5.6±0.01ms 0.00%
Set/FullMerkleTree::::set/100 56.3±0.92ms 56.0±0.05ms -0.53%
Set/FullMerkleTree::::set_range/1 557.6±4.75µs 556.5±4.93µs -0.20%
Set/FullMerkleTree::::set_range/10 760.7±5.21µs 756.4±5.25µs -0.57%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 561.9±2.57µs 557.7±3.71µs -0.75%
Set/OptimalMerkleTree::::set/10 5.6±0.02ms 5.6±0.10ms 0.00%
Set/OptimalMerkleTree::::set/100 56.0±0.18ms 55.9±0.11ms -0.18%
Set/OptimalMerkleTree::::set_range/1 560.8±4.93µs 558.9±5.70µs -0.34%
Set/OptimalMerkleTree::::set_range/10 5.6±0.02ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.1±0.17ms 55.9±0.14ms -0.36%
arkzkey::arkzkey_from_raw_compressed 339.2±0.50ms 340.5±0.52ms +0.38%
arkzkey::arkzkey_from_raw_uncompressed 6.0±0.03ms 6.0±0.02ms 0.00%
vk::vk_from_ark_serialized 1635.3±15.40ns 1628.3±10.34ns -0.43%
zkey::zkey_from_raw 3.5±0.01s 3.4±0.00s -2.86%

Clean up project structure by removing the rln-wasm package, associated GitHub workflows, and WASM-specific configurations. This includes:
- Removing rln-wasm directory and its contents
- Updating Cargo.toml workspace configuration
- Removing WASM-specific build and test configurations from CI workflows
- Removing WASM-related dependencies and features from RLN crate
Copy link

github-actions bot commented Feb 5, 2025

Benchmark for a3c9d55

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 856.8±6.99ns 877.9±25.46ns +2.46%
FullMerkleTree::get 3.5±0.07ns 3.5±0.05ns 0.00%
FullMerkleTree::get_empty_leaves_indices 7.5±0.08ns 7.5±0.08ns 0.00%
FullMerkleTree::get_subtree_root 3.7±0.09ns 3.7±0.10ns 0.00%
FullMerkleTree::override_range 1345.6±6.68ns 1331.0±9.57ns -1.09%
FullMerkleTree::set 869.5±9.61ns 877.1±6.46ns +0.87%
OptimalMerkleTree::compute_root 1016.1±18.17ns 1005.6±8.06ns -1.03%
OptimalMerkleTree::delete 998.1±11.48ns 1002.3±6.23ns +0.42%
OptimalMerkleTree::get 23.3±0.23ns 22.2±0.18ns -4.72%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.08ns 7.5±0.12ns 0.00%
OptimalMerkleTree::get_subtree_root 24.0±0.26ns 24.0±0.46ns 0.00%
OptimalMerkleTree::override_range 4.1±0.03µs 4.1±0.15µs 0.00%
OptimalMerkleTree::set 997.6±6.26ns 1002.6±27.47ns +0.50%

Copy link

github-actions bot commented Feb 5, 2025

Benchmark for d09290f

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 862.5±10.61ns 882.9±5.83ns +2.37%
FullMerkleTree::get 3.5±0.20ns 3.4±0.02ns -2.86%
FullMerkleTree::get_empty_leaves_indices 7.5±0.10ns 7.5±0.10ns 0.00%
FullMerkleTree::get_subtree_root 3.7±0.11ns 3.6±0.08ns -2.70%
FullMerkleTree::override_range 1331.0±46.25ns 1342.9±12.03ns +0.89%
FullMerkleTree::set 855.6±11.63ns 877.8±12.29ns +2.59%
OptimalMerkleTree::compute_root 1004.7±6.38ns 1040.9±37.91ns +3.60%
OptimalMerkleTree::delete 994.6±7.97ns 1018.2±28.00ns +2.37%
OptimalMerkleTree::get 22.5±0.29ns 22.0±0.16ns -2.22%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.10ns 7.5±0.13ns 0.00%
OptimalMerkleTree::get_subtree_root 23.8±0.29ns 24.4±0.30ns +2.52%
OptimalMerkleTree::override_range 4.1±0.10µs 4.1±0.14µs 0.00%
OptimalMerkleTree::set 995.1±6.84ns 1013.9±7.17ns +1.89%

Copy link

github-actions bot commented Feb 5, 2025

Benchmark for a3c9d55

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 13.9±0.10ms 13.3±0.09ms -4.32%
OptimalMerkleTree::::full_height_gen 580.1±7.69µs 592.0±5.28µs +2.05%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 360.8±4.26ns 362.2±4.84ns +0.39%
Pmtree::get_empty_leaves_indices 8.7±0.14ns 9.0±0.11ns +3.45%
Pmtree::get_subtree_root 510.8±3.99ns 517.4±6.11ns +1.29%
Pmtree::override_range 233.1±4.80µs 236.2±5.61µs +1.33%
Pmtree::set 54.5±0.58µs 54.6±0.66µs +0.18%
Pmtree:delete 54.7±0.50µs 54.7±0.57µs 0.00%
Set/FullMerkleTree::::set/1 560.7±3.21µs 564.0±2.95µs +0.59%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.7±0.02ms +1.79%
Set/FullMerkleTree::::set/100 55.8±0.11ms 56.5±0.12ms +1.25%
Set/FullMerkleTree::::set_range/1 559.4±1.94µs 566.1±10.05µs +1.20%
Set/FullMerkleTree::::set_range/10 761.9±8.22µs 769.7±9.18µs +1.02%
Set/FullMerkleTree::::set_range/100 3.3±0.00ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 561.8±6.64µs 563.3±5.28µs +0.27%
Set/OptimalMerkleTree::::set/10 5.6±0.05ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set/100 56.3±0.15ms 56.3±0.36ms 0.00%
Set/OptimalMerkleTree::::set_range/1 562.3±6.61µs 563.7±5.29µs +0.25%
Set/OptimalMerkleTree::::set_range/10 5.6±0.01ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.1±0.12ms 56.3±0.29ms +0.36%
vk::vk_from_ark_serialized 1578.1±8.68ns 1611.4±12.09ns +2.11%
zkey::zkey_from_raw 3.5±0.00s 3.4±0.00s -2.86%

Copy link

github-actions bot commented Feb 5, 2025

Benchmark for b2696c8

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 859.1±22.85ns 890.9±37.44ns +3.70%
FullMerkleTree::get 3.5±0.09ns 3.4±0.04ns -2.86%
FullMerkleTree::get_empty_leaves_indices 7.5±0.06ns 7.8±0.11ns +4.00%
FullMerkleTree::get_subtree_root 3.7±0.10ns 3.6±0.08ns -2.70%
FullMerkleTree::override_range 1315.6±16.25ns 1356.7±13.81ns +3.12%
FullMerkleTree::set 870.0±38.57ns 872.7±18.21ns +0.31%
OptimalMerkleTree::compute_root 1005.9±6.61ns 1010.9±11.76ns +0.50%
OptimalMerkleTree::delete 1001.2±24.78ns 1003.1±14.24ns +0.19%
OptimalMerkleTree::get 22.5±0.26ns 22.5±0.26ns 0.00%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.11ns 7.5±0.10ns 0.00%
OptimalMerkleTree::get_subtree_root 24.1±0.86ns 24.5±0.33ns +1.66%
OptimalMerkleTree::override_range 4.1±0.03µs 4.2±0.15µs +2.44%
OptimalMerkleTree::set 1002.4±29.35ns 1003.5±29.27ns +0.11%

Copy link

github-actions bot commented Feb 5, 2025

Benchmark for d09290f

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.2±0.15ms 13.3±0.10ms -6.34%
OptimalMerkleTree::::full_height_gen 581.2±2.95µs 584.9±6.01µs +0.64%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 359.3±4.58ns 365.1±4.48ns +1.61%
Pmtree::get_empty_leaves_indices 8.7±0.11ns 9.2±0.54ns +5.75%
Pmtree::get_subtree_root 508.3±4.83ns 520.3±6.69ns +2.36%
Pmtree::override_range 234.2±4.36µs 241.6±3.21µs +3.16%
Pmtree::set 54.3±0.74µs 54.8±0.56µs +0.92%
Pmtree:delete 54.4±0.84µs 55.0±0.54µs +1.10%
Set/FullMerkleTree::::set/1 563.4±3.87µs 565.1±13.54µs +0.30%
Set/FullMerkleTree::::set/10 5.7±0.12ms 5.6±0.02ms -1.75%
Set/FullMerkleTree::::set/100 56.4±0.26ms 56.5±0.37ms +0.18%
Set/FullMerkleTree::::set_range/1 563.5±4.59µs 564.3±4.07µs +0.14%
Set/FullMerkleTree::::set_range/10 766.3±7.23µs 767.8±11.64µs +0.20%
Set/FullMerkleTree::::set_range/100 3.3±0.07ms 3.3±0.02ms 0.00%
Set/OptimalMerkleTree::::set/1 564.2±8.32µs 562.1±2.63µs -0.37%
Set/OptimalMerkleTree::::set/10 5.6±0.04ms 5.6±0.02ms 0.00%
Set/OptimalMerkleTree::::set/100 56.1±0.23ms 56.3±0.06ms +0.36%
Set/OptimalMerkleTree::::set_range/1 563.2±4.38µs 566.5±7.04µs +0.59%
Set/OptimalMerkleTree::::set_range/10 5.6±0.01ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.2±0.16ms 56.4±0.16ms +0.36%
vk::vk_from_ark_serialized 1572.3±9.85ns 1662.6±8.74ns +5.74%
zkey::zkey_from_raw 3.5±0.00s 3.4±0.01s -2.86%

Copy link

github-actions bot commented Feb 5, 2025

Benchmark for a3c9d55

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.4±0.41ms 13.7±0.30ms -4.86%
OptimalMerkleTree::::full_height_gen 584.3±29.86µs 577.0±5.06µs -1.25%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 361.9±5.51ns 359.4±6.50ns -0.69%
Pmtree::get_empty_leaves_indices 8.7±0.10ns 8.7±0.16ns 0.00%
Pmtree::get_subtree_root 509.7±8.31ns 511.1±10.32ns +0.27%
Pmtree::override_range 238.2±4.06µs 235.2±5.82µs -1.26%
Pmtree::set 54.9±0.61µs 54.4±0.57µs -0.91%
Pmtree:delete 54.6±0.64µs 54.4±0.48µs -0.37%
Set/FullMerkleTree::::set/1 567.0±4.77µs 555.5±4.73µs -2.03%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.6±0.10ms 0.00%
Set/FullMerkleTree::::set/100 55.9±0.05ms 55.6±0.29ms -0.54%
Set/FullMerkleTree::::set_range/1 566.0±5.13µs 555.6±6.02µs -1.84%
Set/FullMerkleTree::::set_range/10 763.7±6.22µs 754.6±7.26µs -1.19%
Set/FullMerkleTree::::set_range/100 3.3±0.00ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 563.6±6.75µs 556.8±5.69µs -1.21%
Set/OptimalMerkleTree::::set/10 5.6±0.06ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set/100 56.2±0.31ms 55.8±0.35ms -0.71%
Set/OptimalMerkleTree::::set_range/1 564.6±8.83µs 558.1±5.73µs -1.15%
Set/OptimalMerkleTree::::set_range/10 5.6±0.02ms 5.6±0.02ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.2±0.14ms 55.8±0.16ms -0.71%
arkzkey::arkzkey_from_raw_compressed 338.4±0.28ms 338.1±0.43ms -0.09%
arkzkey::arkzkey_from_raw_uncompressed 6.0±0.01ms 6.1±0.03ms +1.67%
vk::vk_from_ark_serialized 1607.0±14.29ns 1605.7±27.33ns -0.08%
zkey::zkey_from_raw 3.5±0.00s 3.4±0.00s -2.86%

Copy link

github-actions bot commented Feb 5, 2025

Benchmark for b2696c8

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.1±0.11ms 13.6±0.19ms -3.55%
OptimalMerkleTree::::full_height_gen 582.8±5.72µs 585.1±4.60µs +0.39%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 389.1±4.78ns 358.8±3.14ns -7.79%
Pmtree::get_empty_leaves_indices 8.7±0.07ns 9.0±0.13ns +3.45%
Pmtree::get_subtree_root 505.4±6.76ns 513.7±5.47ns +1.64%
Pmtree::override_range 239.3±4.39µs 245.1±4.52µs +2.42%
Pmtree::set 54.8±0.69µs 54.6±0.36µs -0.36%
Pmtree:delete 55.0±0.53µs 55.0±2.53µs 0.00%
Set/FullMerkleTree::::set/1 559.6±3.73µs 563.6±9.56µs +0.71%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.6±0.04ms 0.00%
Set/FullMerkleTree::::set/100 56.2±0.16ms 56.5±0.14ms +0.53%
Set/FullMerkleTree::::set_range/1 558.0±2.74µs 562.8±5.85µs +0.86%
Set/FullMerkleTree::::set_range/10 761.6±4.68µs 768.9±5.24µs +0.96%
Set/FullMerkleTree::::set_range/100 3.3±0.05ms 3.3±0.08ms 0.00%
Set/OptimalMerkleTree::::set/1 561.8±5.96µs 563.9±9.05µs +0.37%
Set/OptimalMerkleTree::::set/10 5.6±0.03ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set/100 56.0±0.08ms 56.4±0.38ms +0.71%
Set/OptimalMerkleTree::::set_range/1 560.2±4.87µs 562.9±2.76µs +0.48%
Set/OptimalMerkleTree::::set_range/10 5.6±0.01ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.1±0.15ms 56.7±1.46ms +1.07%
vk::vk_from_ark_serialized 1580.9±9.19ns 1671.6±59.21ns +5.74%
zkey::zkey_from_raw 3.5±0.00s 3.4±0.00s -2.86%

Copy link

github-actions bot commented Feb 5, 2025

Benchmark for d09290f

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.4±0.13ms 13.7±0.09ms -4.86%
OptimalMerkleTree::::full_height_gen 583.7±6.06µs 580.9±5.98µs -0.48%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 358.3±5.44ns 353.4±5.00ns -1.37%
Pmtree::get_empty_leaves_indices 11.3±0.23ns 8.7±0.10ns -23.01%
Pmtree::get_subtree_root 511.8±7.39ns 510.7±9.24ns -0.21%
Pmtree::override_range 239.4±3.32µs 245.3±3.25µs +2.46%
Pmtree::set 54.4±0.60µs 55.2±5.69µs +1.47%
Pmtree:delete 54.5±0.71µs 54.1±0.57µs -0.73%
Set/FullMerkleTree::::set/1 560.2±3.34µs 554.1±4.15µs -1.09%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.6±0.08ms 0.00%
Set/FullMerkleTree::::set/100 56.7±1.95ms 55.6±0.07ms -1.94%
Set/FullMerkleTree::::set_range/1 558.8±2.95µs 555.3±3.43µs -0.63%
Set/FullMerkleTree::::set_range/10 765.7±5.42µs 755.6±13.34µs -1.32%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.02ms 0.00%
Set/OptimalMerkleTree::::set/1 562.5±5.48µs 558.1±2.28µs -0.78%
Set/OptimalMerkleTree::::set/10 5.6±0.03ms 5.7±0.23ms +1.79%
Set/OptimalMerkleTree::::set/100 56.2±0.08ms 55.7±0.20ms -0.89%
Set/OptimalMerkleTree::::set_range/1 561.5±6.36µs 559.1±5.42µs -0.43%
Set/OptimalMerkleTree::::set_range/10 5.6±0.03ms 5.6±0.37ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.3±0.12ms 55.9±0.34ms -0.71%
arkzkey::arkzkey_from_raw_compressed 338.9±1.03ms 339.0±1.43ms +0.03%
arkzkey::arkzkey_from_raw_uncompressed 6.0±0.02ms 6.1±0.04ms +1.67%
vk::vk_from_ark_serialized 1614.6±27.62ns 1603.8±16.07ns -0.67%
zkey::zkey_from_raw 3.5±0.01s 3.4±0.01s -2.86%

Copy link

github-actions bot commented Feb 5, 2025

Benchmark for b2696c8

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 15.1±0.08ms 13.7±0.14ms -9.27%
OptimalMerkleTree::::full_height_gen 588.0±8.16µs 578.5±10.07µs -1.62%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 354.5±5.66ns 356.5±4.75ns +0.56%
Pmtree::get_empty_leaves_indices 8.7±0.16ns 8.8±0.24ns +1.15%
Pmtree::get_subtree_root 513.1±6.58ns 512.7±14.53ns -0.08%
Pmtree::override_range 239.1±4.29µs 238.0±3.80µs -0.46%
Pmtree::set 55.2±2.89µs 54.2±0.71µs -1.81%
Pmtree:delete 54.4±0.30µs 54.2±0.57µs -0.37%
Set/FullMerkleTree::::set/1 561.4±5.44µs 554.7±8.32µs -1.19%
Set/FullMerkleTree::::set/10 5.6±0.01ms 5.6±0.02ms 0.00%
Set/FullMerkleTree::::set/100 56.1±0.23ms 55.5±0.14ms -1.07%
Set/FullMerkleTree::::set_range/1 560.6±4.39µs 554.5±5.20µs -1.09%
Set/FullMerkleTree::::set_range/10 763.8±8.82µs 753.7±4.53µs -1.32%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 563.3±8.47µs 561.0±7.07µs -0.41%
Set/OptimalMerkleTree::::set/10 5.6±0.03ms 5.6±0.02ms 0.00%
Set/OptimalMerkleTree::::set/100 56.3±0.15ms 56.2±0.14ms -0.18%
Set/OptimalMerkleTree::::set_range/1 563.8±10.12µs 555.9±5.18µs -1.40%
Set/OptimalMerkleTree::::set_range/10 5.6±0.01ms 5.6±0.05ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.3±0.18ms 56.0±0.20ms -0.53%
arkzkey::arkzkey_from_raw_compressed 338.7±0.67ms 338.4±0.96ms -0.09%
arkzkey::arkzkey_from_raw_uncompressed 6.1±0.03ms 6.1±0.03ms 0.00%
vk::vk_from_ark_serialized 1629.9±13.41ns 1606.9±19.64ns -1.41%
zkey::zkey_from_raw 3.5±0.01s 3.4±0.01s -2.86%

@seemenkina seemenkina marked this pull request as ready for review February 6, 2025 07:17
@AlekseiVambol
Copy link
Contributor

When "make installdeps" and "make test" are executed, which is specified in the main README file, errors occur. No other suspicious things have been found.

@seemenkina
Copy link
Collaborator Author

When "make installdeps" and "make test" are executed, which is specified in the main README file, errors occur. No other suspicious things have been found.

could you provide log for make installdeps, because on my machine it works correctly

for make test it makes sense, I'll update makefile

@AlekseiVambol
Copy link
Contributor

AlekseiVambol commented Feb 6, 2025

UPDATE: The problem with make installdeps was on my side.

When "make installdeps" and "make test" are executed, which is specified in the main README file, errors occur. No other suspicious things have been found.

could you provide log for make installdeps, because on my machine it works correctly

for make test it makes sense, I'll update makefile

The part containing warnings and errors:
изображение

Copy link

github-actions bot commented Feb 7, 2025

Benchmark for ee23aee

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 855.3±7.10ns 878.4±11.01ns +2.70%
FullMerkleTree::get 3.5±0.08ns 3.5±0.31ns 0.00%
FullMerkleTree::get_empty_leaves_indices 7.5±0.19ns 7.5±0.15ns 0.00%
FullMerkleTree::get_subtree_root 3.7±0.10ns 3.7±0.23ns 0.00%
FullMerkleTree::override_range 1312.0±9.43ns 1343.2±13.84ns +2.38%
FullMerkleTree::set 870.0±7.54ns 870.7±4.71ns +0.08%
OptimalMerkleTree::compute_root 1007.4±13.71ns 1010.7±11.24ns +0.33%
OptimalMerkleTree::delete 1006.4±51.68ns 1007.6±11.18ns +0.12%
OptimalMerkleTree::get 22.5±0.31ns 22.2±0.17ns -1.33%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.07ns 7.5±0.12ns 0.00%
OptimalMerkleTree::get_subtree_root 23.9±0.21ns 24.4±0.21ns +2.09%
OptimalMerkleTree::override_range 4.1±0.06µs 4.2±0.17µs +2.44%
OptimalMerkleTree::set 998.4±11.81ns 1004.1±10.46ns +0.57%

@seemenkina
Copy link
Collaborator Author

@AlekseiVambol I've fixed problem with make test

Copy link

github-actions bot commented Feb 7, 2025

Benchmark for ee23aee

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.3±0.15ms 13.2±0.22ms -7.69%
OptimalMerkleTree::::full_height_gen 581.2±6.21µs 590.6±26.76µs +1.62%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 357.7±4.50ns 360.7±5.69ns +0.84%
Pmtree::get_empty_leaves_indices 8.7±0.11ns 9.0±0.09ns +3.45%
Pmtree::get_subtree_root 508.0±6.09ns 512.2±3.63ns +0.83%
Pmtree::override_range 235.7±3.42µs 236.0±7.58µs +0.13%
Pmtree::set 54.3±0.59µs 54.9±0.25µs +1.10%
Pmtree:delete 54.4±0.54µs 54.6±0.40µs +0.37%
Set/FullMerkleTree::::set/1 561.7±4.36µs 560.4±5.76µs -0.23%
Set/FullMerkleTree::::set/10 5.6±0.01ms 5.6±0.01ms 0.00%
Set/FullMerkleTree::::set/100 56.2±0.17ms 56.3±0.12ms +0.18%
Set/FullMerkleTree::::set_range/1 561.3±4.61µs 561.7±3.84µs +0.07%
Set/FullMerkleTree::::set_range/10 765.0±3.89µs 769.2±17.05µs +0.55%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 562.0±5.90µs 563.0±4.54µs +0.18%
Set/OptimalMerkleTree::::set/10 5.6±0.01ms 5.6±0.06ms 0.00%
Set/OptimalMerkleTree::::set/100 56.0±0.13ms 56.4±0.15ms +0.71%
Set/OptimalMerkleTree::::set_range/1 561.7±3.40µs 563.2±3.37µs +0.27%
Set/OptimalMerkleTree::::set_range/10 5.6±0.02ms 5.6±0.02ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.3±0.33ms 56.4±0.16ms +0.18%
vk::vk_from_ark_serialized 1577.4±24.66ns 1647.8±21.51ns +4.46%
zkey::zkey_from_raw 3.5±0.00s 3.4±0.01s -2.86%

Copy link

github-actions bot commented Feb 7, 2025

Benchmark for ee23aee

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 14.1±0.09ms 13.3±0.12ms -5.67%
OptimalMerkleTree::::full_height_gen 582.3±8.15µs 579.7±9.74µs -0.45%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 359.6±5.54ns 364.6±3.98ns +1.39%
Pmtree::get_empty_leaves_indices 9.6±0.08ns 8.8±0.11ns -8.33%
Pmtree::get_subtree_root 508.8±4.41ns 508.8±5.07ns 0.00%
Pmtree::override_range 233.7±8.70µs 244.4±4.04µs +4.58%
Pmtree::set 54.5±0.42µs 54.3±0.47µs -0.37%
Pmtree:delete 54.5±0.62µs 54.4±0.54µs -0.18%
Set/FullMerkleTree::::set/1 562.2±20.27µs 554.5±6.19µs -1.37%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.5±0.01ms -1.79%
Set/FullMerkleTree::::set/100 56.1±0.17ms 55.6±0.24ms -0.89%
Set/FullMerkleTree::::set_range/1 561.5±3.95µs 554.5±3.74µs -1.25%
Set/FullMerkleTree::::set_range/10 764.1±6.39µs 753.1±5.33µs -1.44%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 562.9±7.15µs 555.4±5.87µs -1.33%
Set/OptimalMerkleTree::::set/10 5.6±0.02ms 5.6±0.03ms 0.00%
Set/OptimalMerkleTree::::set/100 56.4±0.15ms 55.7±0.13ms -1.24%
Set/OptimalMerkleTree::::set_range/1 562.5±4.29µs 555.5±4.03µs -1.24%
Set/OptimalMerkleTree::::set_range/10 5.6±0.01ms 5.6±0.05ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.3±0.12ms 55.6±0.14ms -1.24%
arkzkey::arkzkey_from_raw_compressed 338.5±0.31ms 337.9±0.31ms -0.18%
arkzkey::arkzkey_from_raw_uncompressed 6.0±0.01ms 6.0±0.02ms 0.00%
vk::vk_from_ark_serialized 1594.2±14.69ns 1633.6±27.17ns +2.47%
zkey::zkey_from_raw 3.5±0.00s 3.4±0.00s -2.86%

@AlekseiVambol
Copy link
Contributor

@AlekseiVambol I've fixed problem with make test

Currently, the tests do not produce errors. No other problems have been found.

@seemenkina seemenkina merged commit 8a3e33b into master Feb 7, 2025
13 checks passed
@seemenkina seemenkina deleted the bump-deps branch February 7, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants