New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(which-pm): simplify yaml loading #201

Open

bluwy wants to merge 1 commit into zkochan:main from bluwy:simplify-which-pm-yaml

Contributor

bluwy commented Aug 31, 2024

Use fs api and js-yaml directly to load yaml file instead of load-yaml-file package. The difference switching to this is:

strip-bom is no longer called. In my tests, having the BOM didn't really affect yaml parsing and it worked fine as before.
Upgraded js-yaml v3 to v4. The migration guide is here. The main difference is that the safeLoad API is renamed to load

NOTE: I also noticed that we could use read-yaml-file from this monorepo, but I feel like using fs + js-yaml directly is simpler.


          refactor(which-pm): simplify yaml loading

67a95ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet