Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ZkProgram #13

Merged
merged 24 commits into from
Sep 27, 2024
Merged

Implement ZkProgram #13

merged 24 commits into from
Sep 27, 2024

Conversation

mitschabaude
Copy link
Collaborator

@mitschabaude mitschabaude commented Sep 25, 2024 •
edited
Loading

Building on #6

  • improve type inference of program from spec
  • add helpers to process input/node data types
  • implement the zkprogram logic which verifies attestations and evaluates the graph of operations

Closes #10

@mitschabaude
remove unused scripts
3123486
@mitschabaude
split out some helper types
5bac6f4
@mitschabaude
more specific types on input to that we can filter out public inputs
12b0254
@mitschabaude
move credential api types in their own file, add type-level tuple filter
5a7824b
@mitschabaude
infer proof public inputs
473cb42
@mitschabaude
attested data aren't public input
66c83e7
@mitschabaude
also infer program inputs properly, and add example of running progra…
ca2b9c6 
…m on attestation
@mitschabaude
minor
088e585
@mitschabaude
inputs as record type to get less confused about arguments
bf5cf02
@mitschabaude
minor
54dbbac
@mitschabaude
Merge branch 'main' into feature/program-impl
15b8557
@mitschabaude
fixup
b7fe718
@mitschabaude
make all inputs to spec circuit derived from a root node
d6e6d11
@mitschabaude
some notes / autoformat
b1bcca4
@mitschabaude
Merge branch 'feature/program-impl' of github.com:zksecurity/mina-att…
b21b3f4 
…estations into feature/program-impl
@mitschabaude
Merge branch 'feature/program-impl' of github.com:zksecurity/mina-att…
8668f53 
…estations into feature/program-impl
@mitschabaude
evaluate output node
2ca3d90
@mitschabaude
improve spec output inference for no data
7487624
@mitschabaude
derive zkprogram types
94d8a77
@mitschabaude
allow nested values where we previously needed a struct
5bf3147
@mitschabaude
recombine program inputs into data root
fc88f5e
@mitschabaude
finish zkprogram circuit
ec2ac98
@mitschabaude
finish zkprogram
e4c7522
@mitschabaude mitschabaude marked this pull request as ready for review September 26, 2024 11:36
martonmoro
martonmoro approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@martonmoro martonmoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mitschabaude mitschabaude merged commit 06862a3 into main Sep 27, 2024
4 checks passed
@mitschabaude mitschabaude deleted the feature/program-impl branch September 27, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martonmoro martonmoro martonmoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the ZkProgram
2 participants
@mitschabaude @martonmoro