Add pub attribute for struct fields #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katat
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Nice!
It would be great to support modifying the struct fields inside the methods, as this pub is also about a whitelist to controlling the values of a struct.
Maybe we can create another PR to implement the mut [arg] as described here.
| fn main(pub beds: Field) { | ||
| let mut room = Room {beds: 2, size: 10}; | ||
| room.beds = beds; // allowed | ||
| room.size = 5; // not allowed |
There was a problem hiding this comment.
We can just test the negative case here. Then the positive tests should cover the rest.
src/inputs.rs
Outdated
| @@ -140,7 +140,7 @@ impl<B: Backend> CompiledCircuit<B> { | |||
|
|
|||
| // parse each field | |||
| let mut res = vec![]; | |||
| for (field_name, field_ty) in fields { | |||
| for (field_name, field_ty, attribute) in fields { | |||
There was a problem hiding this comment.
attribute is not used, so would be better _attribute
src/name_resolution/context.rs
Outdated
| @@ -150,7 +150,7 @@ impl NameResCtx { | |||
| self.resolve(module, true)?; | |||
|
|
|||
| // we resolve the fully-qualified types of the fields | |||
| for (_field_name, field_typ) in fields { | |||
| for (_field_name, field_typ, attribute) in fields { | |||
|
@mimoo may want another pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to resolve #224
Here is my approach:
I introduced a new component
Option<Attribute>tofieldsin order to make use of the already definedPubattribute that is used for public inputs.The tricky part was to check whether we are inside a structs method or not. For that I introduced a new variable inside
TypedFnEnvcalledcurrent_fn_kindthat keeps track of the function we are in. This is further utilized in the type checker.