Introduce mypy type checking

[hukkin]

Closes #13

Fixes the make mypy and tox -e mypy invocations, which used to run unittests, now run mypy.
Fixes all mypy errors.

[hukkin]

Hey @Deniallugo is mypy something that you want in this project? I'm asking because it took some time and effort to make it pass initially, and now after the latest changes there are pretty big merge conflicts (and mypy errors after fixing those), which I don't want to get into fixing if this isn't something you want merged.

[popzxc]

My 5 cents is that mypy is pretty important and it's better to have it. The final decision is up to @Deniallugo though.

[Deniallugo]

Sorry, for the big gap.
I think, that mypy is really important for this product.
So, please use it everywhere

[hukkin]

@Deniallugo 👍 I fixed all the conflicts

[StanislavBreadless]

The optional should've remained here, right? It seems like a part of the typing introduced by the PR

[vyastrebovvareger]

I should work even without it. But yes, you are right. How can I checkout to this branch and fix it by the commit ?

[StanislavBreadless]

I guess the best way is to start the new branch which preserves the history with @hukkin's commits and push it separately

[vyastrebovvareger]

Do you mean checkout the : hukkin/zksync-python repo -> create the separated branch inside the master and do the new PR for that rigtht?

[hukkin]

I've fixed mypy in the current branch for you

[hukkin]

Implicit optional is not PEP484 compliant and mypy will error on it in the future: python/mypy#9091

[vyastrebovvareger]

But It's not all. I'm doing the fixes now. there is only 1 question: Can i push into this repo separated branch, that's it?

[hukkin]

If you have write access to zksync-sdk/zksync-python you can also push to my branch

[vyastrebovvareger]

There must be 1 more thing:
transfer, eth_signature = await self.build_forced_exit(target, token_obj, fee_int
instead of just token

[hukkin]

yeah that's fixed in the commit I made

[vyastrebovvareger]

I do not know but it looks like the some library interface has been changed/updated.

from eth_account.signers.base import BaseAccount now accepts only SignableMessage type. Let looking for fix

Sorry. Looks strange because of: message = encode_defunct(message.encode()) must be type of SignableMessage

[hukkin]

Fixed the mypy error. It's not a change in the API. It's just that eth_account didn't distribute type data before the latest version so mypy was not as strict here before.

[vyastrebovvareger]

I got the same issue with the test_is_public_key_onset. Currently I can't get the point why it's failed

[vyastrebovvareger]

Locally it's working fine

[vyastrebovvareger]

fail of test_is_public_key_onset occurs randomly but as far as I can see it depends on timeout and execution flow.