This repository has been archived by the owner on Apr 27, 2020. It is now read-only.
Retain current context to remove dependency on minikube #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/suite.bats
Outdated
| @@ -3,14 +3,15 @@ | |||
| load helper | |||
|
|
|||
| setup() { | |||
| current_context=$(kubectl config current-context) | |||
There was a problem hiding this comment.
Command substitution should be enclosed by double quotes.
current_context="$(kubectl config current-context)"
Currently test code depend on minikube environment, so test will fail if you use extra environment. This patch removes minikube dependency in test code.
yuanying
force-pushed
the
fix-to-retain-current-context
branch
from
3183bc9 to
0946168
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently test code depend on minikube environment, so test will
fail if you use extra environment.
This patch removes minikube dependency in test code.