This repository has been archived by the owner on Apr 27, 2020. It is now read-only.
Update the base image to ubuntu:18.04 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbrothers
force-pushed
the
update-base-image
branch
from
21c5f35 to
425ce18
Compare
yuanying
reviewed
Aug 27, 2018
ci/pipeline.yml.erb
Outdated
| @@ -24,11 +24,11 @@ resource_types: | |||
| tag: latest | |||
|
|
|||
| resources: | |||
| - name: ubuntu-16.04 | |||
| - name: ubuntu-18.04 | |||
There was a problem hiding this comment.
How about making "ubuntu-18.04" be variable?
There was a problem hiding this comment.
Do you mean that ubuntu-18.04 should be changed to less specific name such as base-image?
There was a problem hiding this comment.
No, we are using ERB, so we can use ruby variable.
There was a problem hiding this comment.
Ah, OK. I understand. I'll do it.
There was a problem hiding this comment.
done. 5f9e1b1
yuanying
approved these changes
Aug 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the base image to ubuntu:18.04.