This repository has been archived by the owner on Apr 27, 2020. It is now read-only.
Accept certificate authority optionally from a file #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanying
reviewed
May 15, 2019
|
@plumenator We are now attending KubeCon EU, so we'll start to review again from May 30. |
added 2 commits
May 21, 2019 10:25
superbrothers
approved these changes
Jun 6, 2019
|
@yuanying PTAL |
yuanying
approved these changes
Jun 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an additional source param called
certificate_authority_filefor a user to be able to provide the certificate authority from a file.This solves e.g., the usecase where the certificate authority might be base64 encoded. With this the base64 decoding can be delegated to a task.
See: #57