fix issue for https://github.com/zlargon/google-tts/issues/33 #37
Conversation
index.js
Outdated
| return key(timeout).then(function (key) { | ||
| return tts(text, key, lang, speed); | ||
| }); | ||
| module.exports = function (text, lang, speed) { |
There was a problem hiding this comment.
I notice that you change the original function from a promise function to a non-promise function. In order to support backward compatibility, I think it is preferable NOT to change the function interface (although API key is not required anymore in this approach).
Could you please change the code back to the original promise interface and original test cases?
Thanks.
There was a problem hiding this comment.
@zlargon thanks for your review
understood I followed your fb
|
Hi @freddiefujiwara, thank you for the PR to implement the #33 (comment) into this library. The new Google TTS API will return the audio base64 encoded string instead of the audio URL. According to the discussion in #33, the change in this PR might not safe, but it looks like the only thing we can do to keep the library works. (remove |
this is urgent fix for 33 please check my code