Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known language codes #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

florabtw
Copy link
Contributor

@florabtw florabtw commented Dec 9, 2020

I'm trying to get rid of google-translate-tts now that this repo has been updated to work with new API, and these language codes are one of the differences that I liked.

But no hard feelings if you don't want the codes in this library, I'll just continue to maintain it separately in google-tts-languages.

Also, happy to change the interface. I'm not good at TS, and I would have preferred googleTTS.languages as the array itself (with the lookup functions bound to it), but I couldn't figure out the correct TS types to make it happen.


To clarify: Not all language codes in the Google TTS documentation are actually supported by the unofficial Google Translate API, which is why the list I have added is not the same as the docs. I've been maintaining my own list for the sake of https://soundoftext.com and the only reason I know to add new ones is because I get emailed from users.

@coveralls
Copy link

coveralls commented Dec 9, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling aec0ae3 on ncpierson:master into 00c0d6b on zlargon:master.

@florabtw
Copy link
Contributor Author

The test failure seems unrelated. It might be that the raw data from google is inconsistent =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants