Update the joining of project_path and project_name to pathlib co…
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, have you tested it works ok? |
zlatko-minev
approved these changes
May 21, 2024
|
There are a few new small changes to fix the linting, you can pull them in |
zlatko-minev
added a commit
that referenced
this pull request
May 21, 2024
* Update README.md (#156) * Update back_box_numeric.py - fix lint error for Qobj import (#155) * Update back_box_numeric.py - fix lint error for Qobj import fix lint error for Qobj import * Update plotting.py colors = None fix lint * Update ansys.py * Update the joining of `project_path` and `project_name` to pathlib convention (#154) --------- Co-authored-by: Barkay Guttel <51173082+bguttel@users.noreply.github.com>
zlatko-minev
added a commit
that referenced
this pull request
May 21, 2024
* Update back_box_numeric.py - fix lint error for Qobj import fix lint error for Qobj import * Update plotting.py colors = None fix lint * Update ansys.py * merge in (#157) * Update README.md (#156) * Update back_box_numeric.py - fix lint error for Qobj import (#155) * Update back_box_numeric.py - fix lint error for Qobj import fix lint error for Qobj import * Update plotting.py colors = None fix lint * Update ansys.py * Update the joining of `project_path` and `project_name` to pathlib convention (#154) --------- Co-authored-by: Barkay Guttel <51173082+bguttel@users.noreply.github.com> --------- Co-authored-by: Barkay Guttel <51173082+bguttel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nvention
Minot update that allows the user to be more flexible with the paths. I did not want to mess other things...