add proto version of Promise#finally in library version and tests

zloirock · Jul 19, 2017 · 0bc7a9e · 0bc7a9e
1 parent fd70e24
commit 0bc7a9e
Show file tree

Hide file tree

Showing 13 changed files with 94 additions and 11 deletions.
diff --git a/client/core.js b/client/core.js
@@ -7513,7 +7513,7 @@ var global = __webpack_require__(2);
 var speciesConstructor = __webpack_require__(59);
 var promiseResolve = __webpack_require__(110);
 
-$export($export.P, 'Promise', { 'finally': function (onFinally) {
+$export($export.P + $export.R, 'Promise', { 'finally': function (onFinally) {
   var C = speciesConstructor(this, core.Promise || global.Promise);
   var isFunction = typeof onFinally == 'function';
   return this.then(

diff --git a/client/core.min.js b/client/core.min.js
diff --git a/client/core.min.js.map b/client/core.min.js.map
diff --git a/client/library.js b/client/library.js
@@ -7026,7 +7026,7 @@ var global = __webpack_require__(2);
 var speciesConstructor = __webpack_require__(54);
 var promiseResolve = __webpack_require__(106);
 
-$export($export.P, 'Promise', { 'finally': function (onFinally) {
+$export($export.P + $export.R, 'Promise', { 'finally': function (onFinally) {
   var C = speciesConstructor(this, core.Promise || global.Promise);
   var isFunction = typeof onFinally == 'function';
   return this.then(

diff --git a/client/library.min.js b/client/library.min.js
diff --git a/client/library.min.js.map b/client/library.min.js.map
diff --git a/client/shim.js b/client/shim.js
@@ -7411,7 +7411,7 @@ var global = __webpack_require__(2);
 var speciesConstructor = __webpack_require__(56);
 var promiseResolve = __webpack_require__(106);
 
-$export($export.P, 'Promise', { 'finally': function (onFinally) {
+$export($export.P + $export.R, 'Promise', { 'finally': function (onFinally) {
   var C = speciesConstructor(this, core.Promise || global.Promise);
   var isFunction = typeof onFinally == 'function';
   return this.then(

diff --git a/client/shim.min.js b/client/shim.min.js
diff --git a/client/shim.min.js.map b/client/shim.min.js.map
diff --git a/library/modules/es7.promise.finally.js b/library/modules/es7.promise.finally.js
@@ -6,7 +6,7 @@ var global = require('./_global');
 var speciesConstructor = require('./_species-constructor');
 var promiseResolve = require('./_promise-resolve');
 
-$export($export.P, 'Promise', { 'finally': function (onFinally) {
+$export($export.P + $export.R, 'Promise', { 'finally': function (onFinally) {
   var C = speciesConstructor(this, core.Promise || global.Promise);
   var isFunction = typeof onFinally == 'function';
   return this.then(

diff --git a/modules/es7.promise.finally.js b/modules/es7.promise.finally.js
@@ -6,7 +6,7 @@ var global = require('./_global');
 var speciesConstructor = require('./_species-constructor');
 var promiseResolve = require('./_promise-resolve');
 
-$export($export.P, 'Promise', { 'finally': function (onFinally) {
+$export($export.P + $export.R, 'Promise', { 'finally': function (onFinally) {
   var C = speciesConstructor(this, core.Promise || global.Promise);
   var isFunction = typeof onFinally == 'function';
   return this.then(

diff --git a/tests/library.js b/tests/library.js
diff --git a/tests/library/es7.promise.finally.ls b/tests/library/es7.promise.finally.ls
@@ -0,0 +1,38 @@
+{module, test} = QUnit
+module \ES7
+{Promise} = core
+
+test 'Promise#finally' (assert)!->
+  assert.isFunction Promise::finally
+  assert.arity Promise::finally, 1
+  assert.nonEnumerable Promise::, \finally
+  assert.ok Promise.resolve(42).finally(->) instanceof Promise, 'returns a promise'
+
+test 'Promise#finally, resolved' (assert)!->
+  assert.expect 3
+  async = assert.async!
+  called = 0
+  arg = void
+  Promise.resolve 42
+    .finally !->
+      called++
+      arg := it
+    .then !->
+      assert.same it, 42 'resolved with a correct value'
+      assert.same called, 1 'onFinally function called one time'
+      assert.same arg, void 'onFinally function called with a correct argument'
+      async!
+
+test 'Promise#finally, rejected' (assert)!->
+  assert.expect 2
+  async = assert.async!
+  called = 0
+  arg = void
+  Promise.reject 42
+    .finally !->
+      called++
+      arg := it
+    .catch !->
+      assert.same called, 1 'onFinally function called one time'
+      assert.same arg, void 'onFinally function called with a correct argument'
+      async!