temporarily drop unspecified special cases from Number.fromString b…

…efore clarification from champions
zloirock · Oct 28, 2023 · ffc6984 · ffc6984
1 parent f7b095e
commit ffc6984
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,7 +3,7 @@
 - Simplified `structuredClone` polyfill, avoided second tree pass in cases of transferring
 - Added support of `SuppressedError` to `structuredClone` polyfill
 - Removed unspecified unnecessary `ArrayBuffer` and `DataView` dependencies of `structuredClone` lack of which could cause errors in some entries in IE10-
-- Fixed handling of fractional number part and some special cases in [`Number.fromString`](https://github.com/tc39/proposal-number-fromstring)
+- Fixed handling of fractional number part in [`Number.fromString`](https://github.com/tc39/proposal-number-fromstring)
 - Compat data improvements:
   - Updated Opera Android 78 compat data mapping
 

diff --git a/packages/core-js/modules/esnext.number.from-string.js b/packages/core-js/modules/esnext.number.from-string.js
@@ -24,13 +24,11 @@ $({ target: 'Number', stat: true, forced: true }, {
     var sign = 1;
     if (typeof string != 'string') throw new $TypeError(INVALID_NUMBER_REPRESENTATION);
     if (!string.length) throw new $SyntaxError(INVALID_NUMBER_REPRESENTATION);
-    if (string === 'NaN') return NaN;
     if (charAt(string, 0) === '-') {
       sign = -1;
       string = stringSlice(string, 1);
-      if (!string.length || string === '0') throw new $SyntaxError(INVALID_NUMBER_REPRESENTATION);
+      if (!string.length) throw new $SyntaxError(INVALID_NUMBER_REPRESENTATION);
     }
-    if (string === 'Infinity') return sign * Infinity;
     var R = radix === undefined ? 10 : toIntegerOrInfinity(radix);
     if (R < 2 || R > 36) throw new $RangeError(INVALID_RADIX);
     if (!exec(valid, string)) throw new $SyntaxError(INVALID_NUMBER_REPRESENTATION);

diff --git a/tests/unit-global/esnext.number.from-string.js b/tests/unit-global/esnext.number.from-string.js
@@ -17,13 +17,6 @@ QUnit.test('Number.fromString', assert => {
   }
   assert.throws(() => fromString('10', -4294967294), RangeError, 'Radix uses ToInteger #1');
 
-  assert.same(fromString('NaN'), NaN);
-  assert.same(fromString('NaN', 2), NaN);
-  assert.same(fromString('Infinity'), Infinity);
-  assert.same(fromString('Infinity', 2), Infinity);
-  assert.same(fromString('-Infinity'), -Infinity);
-  assert.same(fromString('-Infinity', 2), -Infinity);
-
   assert.same(fromString('10', 2.5), 2, 'Radix uses ToInteger #2');
   assert.same(fromString('42'), 42);
   assert.same(fromString('42', 10), 42);
@@ -33,8 +26,8 @@ QUnit.test('Number.fromString', assert => {
 
   assert.same(fromString('0'), 0);
   assert.same(fromString('0', 2), 0);
-  assert.throws(() => fromString('-0'), SyntaxError);
-  assert.throws(() => fromString('-0', 2), SyntaxError);
+  assert.same(fromString('-0'), -0);
+  assert.same(fromString('-0', 2), -0);
 
   assert.throws(() => fromString('0xc0ffee'), SyntaxError);
   assert.throws(() => fromString('0o755'), SyntaxError);

diff --git a/tests/unit-pure/esnext.number.from-string.js b/tests/unit-pure/esnext.number.from-string.js
@@ -16,13 +16,6 @@ QUnit.test('Number.fromString', assert => {
   }
   assert.throws(() => fromString('10', -4294967294), RangeError, 'Radix uses ToInteger #1');
 
-  assert.same(fromString('NaN'), NaN);
-  assert.same(fromString('NaN', 2), NaN);
-  assert.same(fromString('Infinity'), Infinity);
-  assert.same(fromString('Infinity', 2), Infinity);
-  assert.same(fromString('-Infinity'), -Infinity);
-  assert.same(fromString('-Infinity', 2), -Infinity);
-
   assert.same(fromString('10', 2.5), 2, 'Radix uses ToInteger #2');
   assert.same(fromString('42'), 42);
   assert.same(fromString('42', 10), 42);
@@ -32,8 +25,8 @@ QUnit.test('Number.fromString', assert => {
 
   assert.same(fromString('0'), 0);
   assert.same(fromString('0', 2), 0);
-  assert.throws(() => fromString('-0'), SyntaxError);
-  assert.throws(() => fromString('-0', 2), SyntaxError);
+  assert.same(fromString('-0'), -0);
+  assert.same(fromString('-0', 2), -0);
 
   assert.throws(() => fromString('0xc0ffee'), SyntaxError);
   assert.throws(() => fromString('0o755'), SyntaxError);