-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 4.4.4: Uncaught TypeError: Cannot redefine property: then #640
Comments
I run {
configurable: false,
enumerable: true,
value: function()
writable: true
} It seems this error caused by the |
Are you sure that it's a native |
Yes, it's a native I know it's an incorrect behavior :( Are there any work around to solve this issue? If no, I have to downgrade and lock the core-js version to 3.1.4. |
I'll add a workaround. |
thanks for fixing this so quickly @zloirock. Are you planning on releasing the fix anytime soon? I see there's a few unreleased fixes out |
Now I haven't enough time for that. Little later. |
Definitely don't want to rush you because I'm sure you're busy, but wanted to just state that this fix would be super helpful in a few spaces I'm in! :) Hope you can release soon. |
We're seeing 4521 occurrences in the past month: ``` Error: at emitOne (events.js:121:20): Cannot redefine property: then stack at defineProperty (native) nativeDefineProperty at /home/udocker/web-payments-experience/node_modules/fusion-cli/node_modules/core-js/modules/es.symbol.js:104:11 f at /home/udocker/web-payments-experience/node_modules/fusion-cli/node_modules/core-js/internals/hide.js:6:30 hide at /home/udocker/web-payments-experience/node_modules/fusion-cli/node_modules/core-js/internals/redefine.js:35:7 redefine at /home/udocker/web-payments-experience/node_modules/fusion-cli/node_modules/core-js/modules/es.promise.js:281:4 call at /home/udocker/web-payments-experience/webpack/bootstrap:84:21 Object.push.jWX+ at https://d3i4yxtzktqr9n.cloudfront.net/web-payments-experience/client-legacy-vendor-6fa8dbaec985031d91bc.js:81:61695 call at /home/udocker/web-payments-experience/webpack/bootstrap:84:21 Object.push at https://d3i4yxtzktqr9n.cloudfront.net/web-payments-experience/client-legacy-main-5702507d1dcffd2fe721.js:1:1206 call at /home/udocker/web-payments-experience/webpack/bootstrap:84:21 ``` Seems to be caused by zloirock/core-js#640, which affects Android 4.4 devices, which is the minimum support version at Uber. Upgraded by running the following commands: ``` cd public/fusion-cli/ jazelle upgrade core-js@^3.3.0 ``` Co-authored-by: Alexander Smith <amsmith@uber.com> Co-authored-by: Ryan Tsao <rtsao@uber.com> Co-authored-by: Ryan Tsao <ryan.j.tsao@gmail.com>
https://github.com/uber/fusionjs/pull/723 We're seeing 4521 occurrences in the past month: ``` Error: at emitOne (events.js:121:20): Cannot redefine property: then stack at defineProperty (native) nativeDefineProperty at /home/udocker/web-payments-experience/node_modules/fusion-cli/node_modules/core-js/modules/es.symbol.js:104:11 f at /home/udocker/web-payments-experience/node_modules/fusion-cli/node_modules/core-js/internals/hide.js:6:30 hide at /home/udocker/web-payments-experience/node_modules/fusion-cli/node_modules/core-js/internals/redefine.js:35:7 redefine at /home/udocker/web-payments-experience/node_modules/fusion-cli/node_modules/core-js/modules/es.promise.js:281:4 call at /home/udocker/web-payments-experience/webpack/bootstrap:84:21 Object.push.jWX+ at https://d3i4yxtzktqr9n.cloudfront.net/web-payments-experience/client-legacy-vendor-6fa8dbaec985031d91bc.js:81:61695 call at /home/udocker/web-payments-experience/webpack/bootstrap:84:21 Object.push at https://d3i4yxtzktqr9n.cloudfront.net/web-payments-experience/client-legacy-main-5702507d1dcffd2fe721.js:1:1206 call at /home/udocker/web-payments-experience/webpack/bootstrap:84:21 ``` Seems to be caused by zloirock/core-js#640, which affects Android 4.4 devices, which is the minimum support version at Uber. Upgraded by running the following commands: ``` cd public/fusion-cli/ jazelle upgrade core-js@^3.3.0 ``` Co-authored-by: Ryan Tsao <rtsao@uber.com>
As title, this error throwed in some old Android devices (such as 4.4.4 KTU84P), due to core-js try to redefine the native promise.
I've looked at #615, but seems not the same issue.
The text was updated successfully, but these errors were encountered: