Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify expression. #1029

Merged
merged 2 commits into from
Dec 30, 2021
Merged

refactor: simplify expression. #1029

merged 2 commits into from
Dec 30, 2021

Conversation

zhangenming
Copy link
Contributor

No description provided.

@zloirock
Copy link
Owner

Thanks, but in this case, we lose check of the existence of the passed method. Something like this:

uncurryThis(Array.prototype.groupBy); // => method or, if `groupBy` is not exist, `undefined`

@zloirock
Copy link
Owner

I don't think that it's a simplification - for many, the first line will seem even more confusing and this does not affect performance, however, let it be.

@zloirock zloirock merged commit b64a3a9 into zloirock:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants