Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a couple linters for checking for common performance improvements + fixes found issues #380

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Adds a couple linters for checking for common performance improvements + fixes found issues #380

merged 8 commits into from
Jun 11, 2024

Conversation

phillip-stephens
Copy link
Contributor

@phillip-stephens phillip-stephens commented Jun 10, 2024 •
edited
Loading

Changes

  • Noticed there was a duplicate function called GetDNSServers with the same implementation. Removed dupe
  • Added the following:
    - fatcontext # detects nested contexts in loops
    - prealloc # suggests to preallocate slices
    - perfsprint # avoid using fmt.Sprintf if a faster alternative exists

@phillip-stephens phillip-stephens marked this pull request as ready for review June 11, 2024 03:14
@phillip-stephens phillip-stephens requested a review from a team as a code owner June 11, 2024 03:14
@phillip-stephens phillip-stephens requested a review from zakird June 11, 2024 03:14
@zakird zakird merged commit 6cc15c1 into main Jun 11, 2024
4 checks passed
@zakird zakird deleted the phillip/lint-performance branch June 11, 2024 03:15
@phillip-stephens phillip-stephens mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakird zakird zakird approved these changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillip-stephens @zakird