Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CNAME loop test to integration #399

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Add a CNAME loop test to integration #399

merged 7 commits into from
Aug 1, 2024

Conversation

phillip-stephens
Copy link
Contributor

Closes #92

DNS Setup

  • cname-loop.zdns-testing.com CNAME cname-loop.esrg.stanford.edu
  • cname-loop.esrg.stanford.edu CNAME cname-loop.zdns-testing.com

Description

  • Added CNAME loop integration test

@phillip-stephens
Copy link
Contributor Author

phillip-stephens commented Jul 17, 2024 •
edited
Loading

This won't pass until #347 is merged, but it passes locally when run with that code. Leaving PR in draft stage so I don't forget about it.

@phillip-stephens phillip-stephens marked this pull request as ready for review July 17, 2024 15:14
@phillip-stephens phillip-stephens requested a review from a team as a code owner July 17, 2024 15:14
@zakird
Copy link
Member

zakird commented Jul 31, 2024

@phillip-stephens looks like there's a merge conflict with recent DNS changes. Can you update and then we can merge?

@zakird zakird merged commit 0a02b64 into main Aug 1, 2024
3 checks passed
@zakird zakird deleted the phillip/92-cname-loop-test branch August 1, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakird zakird zakird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CNAME Loop Test
2 participants
@phillip-stephens @zakird