Fix --class not being respected by CLI
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zakird WDYT, should we explicitly warn users with non-basic modules that |
zakird
approved these changes
Aug 23, 2024
|
I don't have strong opinions, I don't actually know the use case when you'd want this to be different, so I think take the path of least resistance and we can revisit if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #426
NOTE - presently, all modules hard-code
INETas the class, exceptBINDVERSIONwhich sets it asCHAOS. This is not changed in this PR.Description
Classfield so user's --class choice is respectedTesting
It's not really possible (that I can figure) how to test this in integration tests. Running
tcpdumpand evaluating the output seems iffy on random CI systems and no DNS server seemed to respond when I set the class as anything other thanINET, so I ended up just showing both in Wireshark.With Wireshark, I ran
./zdns A zdns-testing.com --name-servers=1.1.1.1 --class=CHAOSwith the Display Filtersudo tcpdump -i en0 udp dst port 53 and dst host 1.1.1.1mainPhillip/426...