Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smb: fix panic in ntlmssp when unmarshaling #333

Merged
merged 2 commits into from
Nov 17, 2021
Merged

smb: fix panic in ntlmssp when unmarshaling #333

merged 2 commits into from
Nov 17, 2021

Commits on Nov 11, 2021

  1. smb: panic in ntlmssp when unmarshaling 

    There are two errors here:

1. The offsets to the ParentBuf are not checked to be in-bounds
2. Types are uint64, but subtracted and compared to > 0.  This allows
   underflow during subtraction of the size.
    @codyprime
    codyprime committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    28e7e4d View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. smb: check offset/length/size are positive after cast

    @codyprime
    codyprime committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    62f891b View commit details
    Browse the repository at this point in the history