Skip to content

Commit

Permalink
Bc critical (#722)
Browse files Browse the repository at this point in the history
* lint about the encoding of qcstatements for PSD2

* Revert "lint about the encoding of qcstatements for PSD2"

This reverts commit 6c23670.

* util: gtld_map autopull updates for 2021-10-21T07:25:20 UTC

* always check and perform the operation in the execution

* returning fatal rather than na

* Update v3/lints/rfc/lint_basic_constraints_not_critical.go

Error instead of fatal

Co-authored-by: Christopher Henderson <chris@chenderson.org>

* adding error description.

---------

Co-authored-by: mtg <git@mtg.de>
Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: Christopher Henderson <chris@chenderson.org>
  • Loading branch information
4 people authored Jun 25, 2023
1 parent 3746088 commit 5e0219d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions v3/lints/rfc/lint_basic_constraints_not_critical.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,8 @@ func (l *basicConstCrit) Execute(c *x509.Certificate) *lint.LintResult {
if e.Critical {
return &lint.LintResult{Status: lint.Pass}
} else {
return &lint.LintResult{Status: lint.Error}
return &lint.LintResult{Status: lint.Error, Details: "Basic Constraints extension is marked as non-critical"}
}
} else {
return &lint.LintResult{Status: lint.NA}
}
return &lint.LintResult{Status: lint.Error, Details: "Error processing Basic Constraints extension"}
}

0 comments on commit 5e0219d

Please sign in to comment.