Fix eku check for BRs #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadrian
approved these changes
Sep 6, 2017
util/eku.go
Outdated
| @@ -0,0 +1,17 @@ | |||
| package util | |||
There was a problem hiding this comment.
May as well just make this part of ca.go. https://github.com/zmap/zlint/blob/master/util/ca.go
| @@ -97,6 +98,9 @@ func (l *Lint) CheckEffective(c *x509.Certificate) bool { | |||
| // CheckEffective() | |||
| // Execute() | |||
There was a problem hiding this comment.
Can you update the first paragraph of the above comment to describe the additional checks you just added, e.g. lints that are checking for BR compliance are only ran against certs that fall under the purview of the BR's.
|
Does this work for CA certificates? |
|
@titanous can you take a look at this too? |
titanous
requested changes
Sep 6, 2017
util/ca.go
Outdated
| @@ -29,3 +29,15 @@ func IsSelfSigned(c *x509.Certificate) bool { | |||
| func IsSubscriberCert(c *x509.Certificate) bool { | |||
| return !IsCACert(c) && !IsSelfSigned(c) | |||
| } | |||
|
|
|||
| func IsTestableBRCertificate(cert *x509.Certificate) bool { | |||
There was a problem hiding this comment.
Perhaps this should be renamed? It checks if a certificate can be used for ServerAuth, so IsServerAuthCert or similar?
|
@titanous i've updated the name. |
titanous
approved these changes
Sep 6, 2017
aaomidi
pushed a commit
to aaomidi/zlint
that referenced
this pull request
Nov 29, 2022
aaomidi
pushed a commit
to aaomidi/zlint
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #167