Add Go module support, cleanup Makefile #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 7, 2019 14:52
cpu
commented
Mar 7, 2019
| module github.com/zmap/zlint | ||
|
|
||
| require ( | ||
| github.com/asaskevich/govalidator v0.0.0-20180720115003-f9ffefc3facf |
There was a problem hiding this comment.
It looks like this dependency is only present because govalidator.IsURL is being used in util/fqdn.go. Similarly zcrypto carries a govalidator dep just for IsURL.
It might be nice to knock a dependency off of both projects by implementing this one function in zcrypto.
There was a problem hiding this comment.
I opened zmap/zcrypto#187 on zcrypto for this.
dadrian
approved these changes
Mar 7, 2019
zakird
approved these changes
Mar 7, 2019
|
I agree regarding implementing |
aaomidi
pushed a commit
to aaomidi/zlint
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds support for Go modules and cleans up a little bit. At a high level:
zlint-gtld-updateto the build artifactsmakefileResolves #264