Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding note to README about small PRs #339

Merged
merged 2 commits into from
Dec 28, 2019
Merged

adding note to README about small PRs #339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7cef6a
adding note to README about small PRs
zakird Dec 28, 2019
7fa6959
better text
zakird Dec 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,13 @@ update these expected values when you add/change lints. Please see the
README](https://github.com/zmap/zlint/blob/master/integration/README.md) for
more information.

**Submitting Lints for Review.** We strongly prefer multiple small pull
requests (PR), each of which contain a single lint or a small handful of lints,
over a single large PR. This allows for better code review, faster turnaround
times on comments and merging, as well as for contributors to learn from any
requested changes in the initial round of review. We are happy to wait to cut
new a version of ZLint until a set of PRs have been approved and merged.

Updating the TLD Map
--------------------

Expand Down